Add gem sources --append to add a source as a fallback; Deprecate --add
#8908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preferred way to add sources is usually `--prepend` despite the long term behavior of `--add` appending. Deprecating before 4.0 will allow us to break usage of the less desireable --add behavior and encourage prepend instead.
|
|
||
| source.load_specs :released | ||
| Gem.sources.delete(source) if was_present | ||
| Gem.sources << source |
There was a problem hiding this comment.
Should we code the source dance into Gem::SourceList#append and Gem::SourceList#prepend, and then DRY up both methods in to a single add_source method? We could rename current add_source to deprecated_add_source or something.
Also thinking about naming, should we instead use something like ensure_first or ensure_last? What people normally understands from append or prepend in other classes does not involve moving elements around, just appending or prepending.
There was a problem hiding this comment.
Good point. I'll get that.
martinemde
changed the base branch from
master
to
martinemde/prepend-gem-sources
|
closing, I'm going to merge these two PRs into a single one that does all the sources changes at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Discussion in #8901 made it clear that we need to move to deprecate
gem sources --addbecause it is the less desirable way to add sources and is more likely to cause confusion. We want to steer people toward--prependand the best way to do that is to make them pay attention to the new choices.What is your fix for the problem, implemented in this PR?
This PR builds on the
--prependPR to add--appendwithout changing the behavior of--add(besides a deprecation warning).We can discuss what other changes we want to push right now. I currently have this set up with the intention of removing
--addin rubygems 4.0.Make sure the following tasks are checked