Skip to content

Conversation

@hsbt
Copy link
Member

@hsbt hsbt commented Aug 5, 2025

What was the end-user or developer problem that led to this PR?

from #6464 (comment)

We already removed Gem.datadir at #6469

Gem::Specification#datadir is also no longer used. we should deprecate and remove it.

What is your fix for the problem, implemented in this PR?

Mark to deprecate that.

Make sure the following tasks are checked

@hsbt hsbt force-pushed the deprecate-datadir branch 2 times, most recently from 768547a to e99cdab Compare August 5, 2025 10:44
@hsbt
Copy link
Member Author

hsbt commented Aug 5, 2025

https://github.com/ruby/ruby/blob/d5e7e88f3248c59070b6e0d1dcb1166534d02a02/ext/extmk.rb#L12 load only rubygems/platform. That file also load Gem::Derecate without rubygems.rb.

Because of this, ruby-core tests are failing now.

@hsbt hsbt force-pushed the deprecate-datadir branch from 4f7cf60 to 4925403 Compare August 5, 2025 11:26
@hsbt hsbt merged commit f1152a3 into master Aug 5, 2025
73 checks passed
@hsbt hsbt deleted the deprecate-datadir branch August 5, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants