Fix bundle update foo unable to update foo in an edge case
#8897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-failed-update-to-latest
branch
3 times, most recently
from
342d066 to
4a24b2d
Compare
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-failed-update-to-latest
branch
from
4a24b2d to
eaf6bd1
Compare
If upgrading `foo` needs an indirect dependency to be downgraded, Bundler would not be able to upgrade foo. This is because when calculating the latest resolvable version of foo, Bundler was still adding lower bound requirements on the locked versions of all dependencies to avoid downgrades, effectively pinning foo to a version older than the latest. To fix this, instead of creating a second "unlocked" definition to figure out the latest resolvable version, create a second unlocked resolver, and DO NOT add lower bound requirements to it.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-failed-update-to-latest
branch
from
eaf6bd1 to
00cc0ec
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/fix-failed-update-to-latest
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 4, 2025
…date-to-latest Fix `bundle update foo` unable to update foo in an edge case (cherry picked from commit e38c8fb)
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 9, 2025
…date-to-latest Fix `bundle update foo` unable to update foo in an edge case (cherry picked from commit e38c8fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If a user is explicitly requesting an upgrade of gem
foo, throughbundle update foo, and the latest version offoois resolvable throughbundle installwithout a lockfile, Bundler should be able to upgrade it, even if it requires downgrading an indirect dependency.What is your fix for the problem, implemented in this PR?
The problem is that when calculating the latest resolvable version of foo, Bundler was still adding lower bound requirements on the locked versions of all dependencies to avoid downgrades, effectively pinning foo to a version older than the latest.
To fix this, instead of creating a second "unlocked" definition to figure out the latest resolvable version, create a second unlocked resolver, and DO NOT add lower bound requirements to it.
Closes #8893.
Make sure the following tasks are checked