Skip to content

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Jan 24, 2025

What was the end-user or developer problem that led to this PR?

We originally added this in order to prevent us when making changes to our test setup to break the way ruby-core runs our tests.

However, the way it works now, it breaks too often due to changes in ruby/ruby because of running against a moving unstable target. We still want to find about that kind of breakage, but not on every PR. Our daily jobs achieve that.

What is your fix for the problem, implemented in this PR?

This commit changes the ruby-core job to run against a fixed target (the tag for the latest ruby release), which should still catch the kind of issue we intend to catch here.

Make sure the following tasks are checked

@deivid-rodriguez deivid-rodriguez changed the title Make ruby-core job a non moving target Make ruby-core job use a non moving target Jan 24, 2025
We originally added this in order to prevent us when making changes to
our test setup to break the way ruby-core runs our tests.

However, the way it works now, it breaks too often due to changes in
ruby/ruby because of running against a moving unstable target.

We still want to find out this kind of breakage, but not on every PR.
Our daily jobs achieve that.

This commit changes the ruby-core job to run against a fixed target (the
tag for the latest ruby release), which should still catch the kind of
issue we intend to catch here.
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/make-ruby-core-job-a-non-moving-target branch from 6d5a590 to 9476f1b Compare January 24, 2025 08:26
@deivid-rodriguez
Copy link
Contributor Author

Merging to get CI green.

@deivid-rodriguez deivid-rodriguez merged commit 299fdbf into master Jan 24, 2025
83 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/make-ruby-core-job-a-non-moving-target branch January 24, 2025 10:01
deivid-rodriguez added a commit that referenced this pull request Feb 17, 2025
…e-job-a-non-moving-target

Make ruby-core job use a non moving target

(cherry picked from commit 299fdbf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant