Introduce Spec::Path.sinatra_dependency_paths for sinatra mock server #8414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
force-pushed
the
introduce-sinatra-deps
branch
2 times, most recently
from
14ef7ff to
3b4cdf8
Compare
hsbt
changed the title
hsbt
force-pushed
the
introduce-sinatra-deps
branch
5 times, most recently
from
b0e30e2 to
7a0899c
Compare
deivid-rodriguez
approved these changes
Jan 16, 2025
hsbt
force-pushed
the
introduce-sinatra-deps
branch
from
7a0899c to
0a16815
Compare
deivid-rodriguez
pushed a commit
that referenced
this pull request
Jan 16, 2025
Introduce Spec::Path.sinatra_dependency_paths for sinatra mock server (cherry picked from commit c568cac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We need to add new dependency like logger to 3 places for sinatra mock server.
What is your fix for the problem, implemented in this PR?
I introduced
Spec::Path.sinatra_dependency_pathsfor that. After that, we can add new dependency to one-place.Make sure the following tasks are checked