Fix @licenses array unmarshalling
#8411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
deivid-rodriguez
force-pushed
the
fix-licenses
branch
from
9472877 to
12f3e78
Compare
deivid-rodriguez
approved these changes
Jan 15, 2025
deivid-rodriguez
changed the title
@licenses array unmarshalling@licenses array unmarshalling
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 16, 2025
fix `@licenses` array unmarshalling (cherry picked from commit 08a279c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Unmarshalling a specification incorrectly returns
spec.licenseas an array (["MIT"]) andspec.licensesas a double array ([["MIT"]]). The former should return a string, and the latter should return and array of strings. The issue was introduced in PR #7975. Related issues: #7978What is your fix for the problem, implemented in this PR?
Fixed unmarshalling to remove the wrapping array. Based on the implementation history of
specification.rb, the value of@licenseshas been marshaled as an array since it was added (exactly 🤯) 16 years ago, so we do not need to coerce it to an array: 5fd4904Make sure the following tasks are checked