Revert RubyGems plugins getting loaded on Bundler.require
#8410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/revert-bad-changes
branch
2 times, most recently
from
bf58020 to
ec116c0
Compare
These changes were included when adding bundler plugin hooks for `Bundler.require`, but they seem completely unrelated to that feature, and have caused several issues.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/revert-bad-changes
branch
from
ec116c0 to
8d56551
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 16, 2025
…anges Revert RubyGems plugins getting loaded on `Bundler.require` (cherry picked from commit 859f4f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
As reported in #8383, Bundler is not printing errors when failing to load plugins in situations where they would not happen previously.
What is your fix for the problem, implemented in this PR?
@roberts1000's reproduction and @simi's bisection helped identify #3439 as the culprit.
That PR introduced several changes aimed at loading RubyGems plugins at
Bundler.requiretime.That's what caused this issue and it seems unrelated to introducing new hooks for Bundler plugins.
I think RubyGems plugins were confused with Bundler plugins.
This PR reverts that change.
Fixes #8383.
Make sure the following tasks are checked