Don't fallback to evaluating YAML gemspecs as Ruby code #8404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/dont-fallback-to-evaluating-yaml-gemspecs
branch
from
912997f to
a283a5d
Compare
deivid-rodriguez
force-pushed
the
deivid-rodriguez/dont-fallback-to-evaluating-yaml-gemspecs
branch
from
a283a5d to
ca0a7ff
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/dont-fallback-to-evaluating-yaml-gemspecs
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 16, 2025
…-to-evaluating-yaml-gemspecs Don't fallback to evaluating YAML gemspecs as Ruby code (cherry picked from commit d02443a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When running bundler specs with ruby 3.4, some strange warnings are printed when running the following spec:
https://github.com/rubygems/rubygems/blob/64e0f98f581a399ed34ba729d2967dc3e4b0a31e/bundler/spec/bundler/bundler_spec.rb#L72-L90
Warnings read like this:
This is because when Bundler fails to load a YAML gemspec, it will retry evaluating it as Ruby code, and that causes the warnings.
What is your fix for the problem, implemented in this PR?
I'd say this fallback is not necessary, so I propose to remove it.
Make sure the following tasks are checked