Remove warning by not calling have_library after pkg_config #193
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg_config without the options arguments stores the result in the global
values.
Calling `pkg_config` and `have_library` causes -lffi to appear twice in
the LIBS variable in the resulting Makefile, and causes ld on macOS to
emit a warning:
$ bundle exec rake compile 2>&1 | grep warning:
ld: warning: ignoring duplicate libraries: '-lffi'
etiennebarrie
force-pushed
the
remove-build-warning
branch
from
22212d6 to
03f0ac0
Compare
hsbt
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_config without the options arguments stores the result in the global values.
Calling
pkg_configandhave_librarycauses -lffi to appear twice in the LIBS variable in the resulting Makefile, and causes ld on macOS to emit a warning: