-
Notifications
You must be signed in to change notification settings - Fork 44
CI: Add GitHub Actions ppc64le/s390x cases #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4103ca8
to
68a62ba
Compare
This PR is ready for review. A maintainer working on this repository, could you review this PR? Thank you. |
- run: sudo bundle install --jobs 2 | ||
|
||
- run: rake compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- run: rake compile | |
- run: bundle exec rake compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rake compile
without bundle exec
is to align the current style of the other parts. Below is the current status in the latest master branch. I can send another PR for this change including other parts later.
$ grep -rn 'rake compile' .github/workflows/
.github/workflows/ci.yml:52: - run: rake compile
.github/workflows/libffi.yml:35: run: rake compile -- --with-libffi-dir=${{ matrix.libffi-prefix }}
.github/workflows/libffi.yml:38: run: rake compile -- --with-libffi-source-dir=$(pwd)/libffi-${{ matrix.libffi }}
|
||
- run: rake compile | ||
|
||
- run: ruby -Ilib test/run.rb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- run: ruby -Ilib test/run.rb | |
- run: bundle exec ruby -Ilib test/run.rb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ruby -Ilib test/run.rb
without bundle exec
is to align the current style of the other parts. Below is the current status of the latest master branch. I can send another PR for this change including other parts later.
$ grep -rn 'test/run.rb' .github/workflows/
.github/workflows/ci.yml:63: - run: ruby -Ilib test/run.rb
.github/workflows/ci.yml:78: ruby test/run.rb
68a62ba
to
3217988
Compare
@kou Thank you for your review! I fixed some of things you mentioned. For the style of the commands without |
OK. Let's use another PR. |
Thank you for merging this PR. |
I sent the PR #192 for this now. |
We use the PR description as the commit message of merged commit. |
Sure. I will keep that in mind. If I am missing adding the context of the commit into the commit message in future PRs, please let me know in the review process. I am happy to fix it. |
This PR is working in progress to add GitHub Actions Ubuntu 24.04 ppc64le/s390x cases. This is one of the tasks that we add the cases in some ruby/* repositories. The task is tracked at IBM/actionspz#4 (comment).
Maybe, this PR's change will be for only
.github/workflows/ci.yml
, while you see other changes in other files temporarily to work on this PR easily for now. I needed to sent a PR to this repository to test the ppc64le/s390x CI pipelines, rather than to test on my fork repository because GitHub Actions Ubuntu 24.04 ppc64le/s390x cases don't work in fork repositories unlike GitHub Actions x86_64/arm64 pipelines.I add the new job "host-ibm", because there are ppc64le/s390x specific logic,
if: github.repository == 'ruby/fiddle'
and "Set up Ruby" logic installing Ruby apt package. Theruby/setup-ruby
doesn't support the ppc64le/s390x cases as far as I know.As a reference, we have applied the following code to a few ruby/* repositories.