Skip to content

Conversation

junaruga
Copy link
Member

@junaruga junaruga commented Sep 17, 2025

This PR is working in progress to add GitHub Actions Ubuntu 24.04 ppc64le/s390x cases. This is one of the tasks that we add the cases in some ruby/* repositories. The task is tracked at IBM/actionspz#4 (comment).

Maybe, this PR's change will be for only .github/workflows/ci.yml, while you see other changes in other files temporarily to work on this PR easily for now. I needed to sent a PR to this repository to test the ppc64le/s390x CI pipelines, rather than to test on my fork repository because GitHub Actions Ubuntu 24.04 ppc64le/s390x cases don't work in fork repositories unlike GitHub Actions x86_64/arm64 pipelines.

I add the new job "host-ibm", because there are ppc64le/s390x specific logic, if: github.repository == 'ruby/fiddle' and "Set up Ruby" logic installing Ruby apt package. The ruby/setup-ruby doesn't support the ppc64le/s390x cases as far as I know.

As a reference, we have applied the following code to a few ruby/* repositories.

@junaruga junaruga force-pushed the wip/gha-ppc64le-s390x branch 2 times, most recently from 4103ca8 to 68a62ba Compare September 17, 2025 17:32
@junaruga junaruga changed the title WIP: CI: Add GitHub Actions ppc64le/s390x cases CI: Add GitHub Actions ppc64le/s390x cases Sep 17, 2025
@junaruga junaruga marked this pull request as ready for review September 17, 2025 17:35
@junaruga
Copy link
Member Author

This PR is ready for review. A maintainer working on this repository, could you review this PR? Thank you.

- run: sudo bundle install --jobs 2

- run: rake compile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- run: rake compile
- run: bundle exec rake compile

Copy link
Member Author

@junaruga junaruga Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rake compile without bundle exec is to align the current style of the other parts. Below is the current status in the latest master branch. I can send another PR for this change including other parts later.

$ grep -rn 'rake compile' .github/workflows/
.github/workflows/ci.yml:52:      - run: rake compile
.github/workflows/libffi.yml:35:        run: rake compile -- --with-libffi-dir=${{ matrix.libffi-prefix }}
.github/workflows/libffi.yml:38:        run: rake compile -- --with-libffi-source-dir=$(pwd)/libffi-${{ matrix.libffi }}


- run: rake compile

- run: ruby -Ilib test/run.rb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- run: ruby -Ilib test/run.rb
- run: bundle exec ruby -Ilib test/run.rb

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ruby -Ilib test/run.rb without bundle exec is to align the current style of the other parts. Below is the current status of the latest master branch. I can send another PR for this change including other parts later.

$ grep -rn 'test/run.rb' .github/workflows/
.github/workflows/ci.yml:63:      - run: ruby -Ilib test/run.rb
.github/workflows/ci.yml:78:          ruby test/run.rb

@junaruga junaruga force-pushed the wip/gha-ppc64le-s390x branch from 68a62ba to 3217988 Compare September 19, 2025 15:03
@junaruga
Copy link
Member Author

@kou Thank you for your review! I fixed some of things you mentioned. For the style of the commands without bundle exec, as I see the style in other parts in the current CI yml files, I want to send another PR applying the changes for other parts together later. Is it okay for you? Could you review this PR again? Thank you.

@kou
Copy link
Member

kou commented Sep 19, 2025

OK. Let's use another PR.

@kou kou merged commit 6368ee0 into ruby:master Sep 19, 2025
68 checks passed
@junaruga junaruga deleted the wip/gha-ppc64le-s390x branch September 22, 2025 16:34
@junaruga
Copy link
Member Author

Thank you for merging this PR.
I see the commit 6368ee0 's commit message including this page's first comment. That was my intention. The first comment was before your reviews. So, the content is outdated for example, "Maybe, this PR's change will be for only .github/workflows/ci.yml" was my statement before your review.

@junaruga
Copy link
Member Author

junaruga commented Sep 22, 2025

OK. Let's use another PR.

I sent the PR #192 for this now.

@junaruga junaruga mentioned this pull request Sep 22, 2025
@kou
Copy link
Member

kou commented Sep 22, 2025

We use the PR description as the commit message of merged commit.
Could you also update the PR description next time?

@junaruga
Copy link
Member Author

We use the PR description as the commit message of merged commit. Could you also update the PR description next time?

Sure. I will keep that in mind. If I am missing adding the context of the commit into the commit message in future PRs, please let me know in the review process. I am happy to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants