Enhance BulkChangeTable to support block wrappers #1496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the BulkChangeTable RuboCop would fail to detect consecutive combinable operations if they were wrapped inside blocks like
safety_assured
,reversible
, or other custom methods. This meant that we could miss opportunities to optimize our database migrations with bulk ALTER statements.For example, the following code would not trigger an offense, even though the add_column calls could be combined:
This PR introduces a recursive AST traversal logic that efficiently navigates through nested block structures while preserving the operational context. The BulkChangeTable RuboCop now correctly identifies sequential combinable operations within a wide range of block patterns.
Improvements:
safety_assured
blocks, a key feature of strong_migrations.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.