Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In applications with large route files, its common to have a desire to extract regexes, constraints, etc. that are used multiple times to prevent duplication. If the value is never going to change, extracting the value to a constant would be a very normal thing to do in typical Ruby classes/modules. However, the
config/routes.rb
file is reloadable, so a constant defined there will causing a constant redefinition warning when/if the routes are reloaded (typically during development or test, especially if using Spring).This commit adds a ConstantInRoutes Cop to prevent constants from being defined in
config/routes.rb
files.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.