Suggestion: Rails/FilePath: Use Rails.root.join('path/to').to_path instead of .to_s .

[kaibadash]

Currently, Rails/FilePath recommends using Rails.root.join('app', 'models', 'goober').to_s, but would .to_path be more appropriate?
When we use .to_s, we expect to get its class name and address.

Example:

[1] pry(main)> User.first.to_s
=> “#<User:0x0000ffff7872b6e0>”

Similarly, I'm worried that Rails.root.join('app', 'models', 'goober').to_s might return that.
On the other hand, .to_path does not have this fear. It's an alias to to_s.
https://docs.ruby-lang.org/en/master/Pathname.html#method-i-to_path

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists). : no related issues
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
• If this is a new cop, consider making a corresponding update to the Rails Style Guide.

[koic]

The reasoning makes sense, but this seems like a style discussion that should be proposed (PR or issue) in the Rails Style Guide.
https://github.com/rubocop/rails-style-guide