Simplify introduced GetHashCode and Equals

Author: Vogel612

Rubberduck.Core/UI/UnitTesting/ViewModels/TestMethodViewModel.cs

@@ -26,12 +26,10 @@ public TestResult Result
 
         // Delegate Navigability to encapsulated TestMethod
         public NavigateCodeEventArgs GetNavigationArgs() => Method.GetNavigationArgs();
-        
 
-        public override string ToString()
-        {
-            return $"{Method.Declaration.QualifiedName}: {Result.Outcome} ({Result.Duration}ms) {Result.Output}";
-        }
+        public override string ToString() => $"{Method.Declaration.QualifiedName}: {Result.Outcome} ({Result.Duration}ms) {Result.Output}";
+        public override bool Equals(object obj) => obj is TestMethodViewModel other && Method.Equals(other.Method);
+        public override int GetHashCode() => Method.GetHashCode();
 
         public object[] ToArray()
         {
@@ -45,17 +43,5 @@ public object[] ToArray()
                 _result.Duration
             };
         }
-
-        public override bool Equals(object obj)
-        {
-            var model = obj as TestMethodViewModel;
-            return model != null &&
-                   EqualityComparer<TestMethod>.Default.Equals(Method, model.Method);
-        }
-
-        public override int GetHashCode()
-        {
-            return 1003453392 + EqualityComparer<TestMethod>.Default.GetHashCode(Method);
-        }
     }
 }

Rubberduck.UnitTesting/UnitTesting/TestMethod.cs

@@ -1,13 +1,10 @@
 using System;
-using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using Rubberduck.Parsing;
 using Rubberduck.Parsing.Annotations;
 using Rubberduck.Parsing.Symbols;
-using Rubberduck.Parsing.VBA;
 using Rubberduck.VBEditor;
-using Rubberduck.VBEditor.ComManagement.TypeLibsAPI;
 using Rubberduck.Interaction.Navigation;
 
 namespace Rubberduck.UnitTesting
@@ -37,19 +34,8 @@ public NavigateCodeEventArgs GetNavigationArgs()
             return new NavigateCodeEventArgs(new QualifiedSelection(Declaration.QualifiedName.QualifiedModuleName, Declaration.Context.GetSelection()));
         }
 
-        public bool Equals(TestMethod other)
-        {
-            return other != null && Declaration.QualifiedName.Equals(other.Declaration.QualifiedName);
-        }
-
-        public override bool Equals(object obj)
-        {
-            return obj is TestMethod method && method.Declaration.QualifiedName.Equals(Declaration.QualifiedName);
-        }
-
-        public override int GetHashCode()
-        {
-            return Declaration.QualifiedName.GetHashCode();
-        }
+        public bool Equals(TestMethod other) => other != null && Declaration.QualifiedName.Equals(other.Declaration.QualifiedName);
+        public override bool Equals(object obj) => obj is TestMethod method && Equals(method);
+        public override int GetHashCode() => Declaration.QualifiedName.GetHashCode();
     }
 }

Rubberduck.UnitTesting/UnitTesting/TestResult.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using Rubberduck.VBEditor;
 
 namespace Rubberduck.UnitTesting
 {
@@ -16,27 +15,13 @@ public TestResult(TestOutcome outcome, string output = "", long duration = 0)
         public TestOutcome Outcome { get; private set; }
         public string Output { get; private set; }
 
+        public override int GetHashCode() => HashCode.Compute(Outcome, Output);
+        public override string ToString() => $"{Outcome} ({Duration} ms) {Output}";
         public override bool Equals(object obj)
         {
-            if (obj is TestResult other)
-            {
-                return Outcome == other.Outcome
+            return obj is TestResult other
+                    && Outcome == other.Outcome
                     && Output == other.Output;
-            }
-            return false;
-        }
-
-        public override int GetHashCode()
-        {
-            var hashCode = -1268493841;
-            hashCode = hashCode * -1521134295 + Outcome.GetHashCode();
-            hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(Output);
-            return hashCode;
-        }
-
-        public override string ToString()
-        {
-            return $"{Outcome} ({Duration} ms) {Output}";
         }
     }
 }