Clarify Event semantics for TestRunCompleted

Author: Vogel612

Rubberduck.Core/UI/UnitTesting/TestExplorerModel.cs

@@ -20,15 +20,15 @@ public TestExplorerModel(IVBE vbe, ITestEngine testEngine)
             _vbe = vbe;
             this.testEngine = testEngine;
 
-            testEngine.TestsRefreshed += RefreshTests;
+            testEngine.TestsRefreshed += HandleTestsRefreshed;
             testEngine.TestRunCompleted += HandleRunCompletion;
             testEngine.TestCompleted += HandleTestCompletion;
             _dispatcher = Dispatcher.CurrentDispatcher;
         }
 
-        private void HandleRunCompletion(object sender, long time)
+        private void HandleRunCompletion(object sender, TestRunCompletedEventArgs e)
         {
-            TotalDuration = time;
+            TotalDuration = e.Duration;
             ExecutedCount = Tests.Count(t => t.Result.Outcome != TestOutcome.Unknown);
         }
 
@@ -50,7 +50,7 @@ private void HandleTestCompletion(object sender, TestCompletedEventArgs e)
             RefreshProgressBarColor();
         }
 
-        private void RefreshTests(object sender, EventArgs args)
+        private void HandleTestsRefreshed(object sender, EventArgs args)
         {
             Tests.Clear();
             foreach (var test in testEngine.Tests.Select(test => new TestMethodViewModel(test)))
@@ -130,7 +130,7 @@ public void Dispose()
             if (testEngine != null)
             {
                 testEngine.TestCompleted -= HandleTestCompletion;
-                testEngine.TestsRefreshed -= RefreshTests;
+                testEngine.TestsRefreshed -= HandleTestsRefreshed;
                 testEngine.TestRunCompleted -= HandleRunCompletion;
             }
         }

Rubberduck.UnitTesting/UnitTesting/ITestEngine.cs

@@ -6,7 +6,7 @@ namespace Rubberduck.UnitTesting
     public interface ITestEngine
     {
         event EventHandler<TestCompletedEventArgs> TestCompleted;
-        event EventHandler<long> TestRunCompleted;
+        event EventHandler<TestRunCompletedEventArgs> TestRunCompleted;
         event EventHandler TestsRefreshed;
 
         IEnumerable<TestMethod> Tests { get; }
@@ -30,4 +30,14 @@ public TestCompletedEventArgs(TestMethod test, TestResult result)
             Result = result;
         }
     }
+
+    public class TestRunCompletedEventArgs : EventArgs
+    {
+        public long Duration { get; }
+
+        public TestRunCompletedEventArgs(long duration)
+        {
+            Duration = duration;
+        }
+    }
 }

Rubberduck.UnitTesting/UnitTesting/TestEngine.cs

@@ -99,7 +99,7 @@ private void StateChangedHandler(object sender, ParserStateEventArgs e)
         }
 
         public event EventHandler<TestCompletedEventArgs> TestCompleted;
-        public event EventHandler<long> TestRunCompleted;
+        public event EventHandler<TestRunCompletedEventArgs> TestRunCompleted;
         public event EventHandler TestsRefreshed;
 
         private void OnTestCompleted(TestMethod test, TestResult result)
@@ -268,7 +268,7 @@ private void RunWhileSuspended(IEnumerable<TestMethod> tests)
                 Logger.Error(ex, "Unexpected expection while running unit tests; unit tests will be aborted");
             }
             overallTime.Stop();
-            TestRunCompleted?.Invoke(this, overallTime.ElapsedMilliseconds);
+            TestRunCompleted?.Invoke(this, new TestRunCompletedEventArgs(overallTime.ElapsedMilliseconds));
         }
 
         private TestResult RunTestMethod(ITypeLibWrapper typeLib, TestMethod test)