Stop reporting implicit accesses to worksheets by name in SheetAccessedUsingStringInspection

Unqualified accesses and accesses through Application are accesses on the ActiveWorkbook according to the documentations. That might not be the same workbook as ThisWorkbook.

Author: MDoerner

Rubberduck.CodeAnalysis/Inspections/Concrete/Excel/SheetAccessedUsingStringInspection.cs

@@ -47,9 +47,6 @@ namespace Rubberduck.Inspections.Concrete
     [RequiredLibrary("Excel")]
     public class SheetAccessedUsingStringInspection : IdentifierReferenceInspectionFromDeclarationsBase
     {
-        //TODO: revisit this and its tests after clarification of intended behaviour.
-        //This relates to the handling of implicit references to ActiveWorkbook.
-
         private readonly IProjectsProvider _projectsProvider;
 
         public SheetAccessedUsingStringInspection(RubberduckParserState state, IProjectsProvider projectsProvider)
@@ -65,7 +62,7 @@ public SheetAccessedUsingStringInspection(RubberduckParserState state, IProjects
 
         private static readonly string[] InterestingClasses =
         {
-            "_Global", "_Application", "Global", "Application", "Workbook"
+            "Workbook"
         };
 
         protected override IEnumerable<Declaration> ObjectionableDeclarations(DeclarationFinder finder)

RubberduckTests/Inspections/SheetAccessedUsingStringInspectionTests.cs

@@ -29,28 +29,30 @@ public void SheetAccessedUsingString_ReturnsResult_AccessingUsingWorkbookModule(
 
         [Test]
         [Category("Inspections")]
-        public void SheetAccessedUsingString_ReturnsResult_AccessingUsingApplicationModule()
+        //Access via Application is an access on the ActiveWorkbook, not necessarily ThisWorkbook.
+        public void SheetAccessedUsingString_ReturnsNoResult_AccessingUsingApplicationModule()
         {
             const string inputCode =
                 @"Public Sub Foo()
     Application.Worksheets(""Sheet1"").Range(""A1"") = ""Foo""
     Application.Sheets(""Sheet1"").Range(""A1"") = ""Foo""
 End Sub";
 
-            Assert.AreEqual(2, ArrangeParserAndGetResults(inputCode).Count());
+            Assert.AreEqual(0, ArrangeParserAndGetResults(inputCode).Count());
         }
 
         [Test]
         [Category("Inspections")]
-        public void SheetAccessedUsingString_ReturnsResult_AccessingUsingGlobalModule()
+        //Unqualified access is an access on the ActiveWorkbook, not necessarily ThisWorkbook.
+        public void SheetAccessedUsingString_ReturnsNoResult_AccessingUsingGlobalModule()
         {
             const string inputCode =
                 @"Public Sub Foo()
     Worksheets(""Sheet1"").Range(""A1"") = ""Foo""
     Sheets(""Sheet1"").Range(""A1"") = ""Foo""
 End Sub";
 
-            Assert.AreEqual(2, ArrangeParserAndGetResults(inputCode).Count());
+            Assert.AreEqual(0, ArrangeParserAndGetResults(inputCode).Count());
         }
 
         [Test]

RubberduckTests/QuickFixes/AccessSheetUsingCodeNameQuickFixTests.cs

@@ -31,42 +31,6 @@ Public Sub Foo()
             Assert.AreEqual(expectedCode, actualCode);
         }
 
-        [Test]
-        [Category("QuickFixes")]
-        public void SheetAccessedUsingString_QuickFixWorks_UsingSheetThroughApplicationModule()
-        {
-            const string inputCode = @"
-Public Sub Foo()
-    Application.Sheets(""Sheet1"").Range(""A1"") = ""foo""
-End Sub";
-
-            const string expectedCode = @"
-Public Sub Foo()
-    Sheet1.Range(""A1"") = ""foo""
-End Sub";
-
-            var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new SheetAccessedUsingStringInspection(state, state.ProjectsProvider));
-            Assert.AreEqual(expectedCode, actualCode);
-        }
-
-        [Test]
-        [Category("QuickFixes")]
-        public void SheetAccessedUsingString_QuickFixWorks_UsingSheetThroughGlobalModule()
-        {
-            const string inputCode = @"
-Public Sub Foo()
-    Sheets(""Sheet1"").Range(""A1"") = ""foo""
-End Sub";
-
-            const string expectedCode = @"
-Public Sub Foo()
-    Sheet1.Range(""A1"") = ""foo""
-End Sub";
-
-            var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new SheetAccessedUsingStringInspection(state, state.ProjectsProvider));
-            Assert.AreEqual(expectedCode, actualCode);
-        }
-
         [Test]
         [Category("QuickFixes")]
         public void SheetAccessedUsingString_QuickFixWorks_AssigningSheetToVariable()
@@ -220,70 +184,6 @@ Dim ws As Worksheet
             var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new SheetAccessedUsingStringInspection(state, state.ProjectsProvider));
             Assert.AreEqual(expectedCode, actualCode);
         }
-        
-        [Test]
-        [Category("QuickFixes")]
-        public void SheetAccessedUsingString_QuickFixWorks_TransientReferenceSetStatement()
-        {
-            const string inputCode = @"
-Sub Test()
-    Dim ws As Worksheet
-    Set ws = Worksheets.Add(Worksheets(""Sheet1""))
-    Debug.Print ws.Name
-End Sub";
-
-            const string expectedCode = @"
-Sub Test()
-    Dim ws As Worksheet
-    Set ws = Worksheets.Add(Sheet1)
-    Debug.Print ws.Name
-End Sub";
-
-            var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new SheetAccessedUsingStringInspection(state, state.ProjectsProvider));
-            Assert.AreEqual(expectedCode, actualCode);
-        }
-
-        [Test]
-        [Category("QuickFixes")]
-        public void SheetAccessedUsingString_QuickFixWorks_TransientReferenceNoSetStatement()
-        {
-            const string inputCode = @"
-Sub Test()
-    If Not Worksheets.Add(Worksheets(""Sheet1"")) Is Nothing Then
-        Debug.Print ""Added""
-    End If
-End Sub";
-
-            const string expectedCode = @"
-Sub Test()
-    If Not Worksheets.Add(Sheet1) Is Nothing Then
-        Debug.Print ""Added""
-    End If
-End Sub";
-
-            var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new SheetAccessedUsingStringInspection(state, state.ProjectsProvider));
-            Assert.AreEqual(expectedCode, actualCode);
-        }
-
-        [Test]
-        [Category("QuickFixes")]
-        public void SheetAccessedUsingString_QuickFixWorks_ImplicitVariableAssignment()
-        {
-            const string inputCode = @"
-Sub Test()
-    Set ws = Worksheets(""Sheet1"")
-    ws.Name = ""Foo""
-End Sub";
-
-            const string expectedCode = @"
-Sub Test()
-    
-    Sheet1.Name = ""Foo""
-End Sub";
-
-            var actualCode = ApplyQuickFixToFirstInspectionResult(inputCode, state => new SheetAccessedUsingStringInspection(state, state.ProjectsProvider));
-            Assert.AreEqual(expectedCode, actualCode);
-        }
 
         protected override IQuickFix QuickFix(RubberduckParserState state)
         {