Deal with ToDos needing one of the latest merged PRs

Performance enhancements in some inspections

Author: MDoerner

Rubberduck.CodeAnalysis/Inspections/Abstract/IsMissingInspectionBase.cs

@@ -64,8 +64,9 @@ protected ParameterDeclaration ParameterForReference(ArgumentReference reference
             }
 
             var procedure = reference.Context.GetAncestor<VBAParser.ModuleBodyElementContext>();
-            //TODO: revisit this once PR #5338 is merged.
-            return finder.UserDeclarations(DeclarationType.Member)
+            var module = reference.QualifiedModuleName;
+
+            return finder.Members(module, DeclarationType.Member)
                 .OfType<ModuleBodyElementDeclaration>()
                 .FirstOrDefault(decl => decl.Context.Parent == procedure)?.Parameters
                     .FirstOrDefault(param => param.IdentifierName.Equals(name.GetText()));

Rubberduck.CodeAnalysis/Inspections/Concrete/AssignmentNotUsedInspection.cs

@@ -48,10 +48,8 @@ public AssignmentNotUsedInspection(RubberduckParserState state, Walker walker)
 
         protected override IEnumerable<IdentifierReference> ReferencesInModule(QualifiedModuleName module, DeclarationFinder finder)
         {
-            //TODO: Revisit this once PR #5338 is merged.
-            var localNonArrayVariables = finder.Members(module)
-                .Where(declaration => declaration.DeclarationType == DeclarationType.Variable 
-                                      && !declaration.IsArray
+            var localNonArrayVariables = finder.Members(module, DeclarationType.Variable)
+                .Where(declaration => !declaration.IsArray
                                       && !declaration.ParentScopeDeclaration.DeclarationType.HasFlag(DeclarationType.Module));
             return localNonArrayVariables
                 .Where(declaration => !declaration.IsIgnoringInspectionResultFor(AnnotationName))

Rubberduck.CodeAnalysis/QuickFixes/AccessSheetUsingCodeNameQuickFix.cs

@@ -36,7 +36,7 @@ namespace Rubberduck.Inspections.QuickFixes
     /// ]]>
     /// </after>
     /// </example>
-    public sealed class AccessSheetUsingCodeNameQuickFix : QuickFixBase // fixme: rename as per action(s), not the inspection that uses it
+    public sealed class AccessSheetUsingCodeNameQuickFix : QuickFixBase
     {
         private readonly IDeclarationFinderProvider _declarationFinderProvider;
 

Rubberduck.CodeAnalysis/QuickFixes/PassParameterByValueQuickFix.cs

@@ -35,19 +35,18 @@ namespace Rubberduck.Inspections.QuickFixes
     /// </example>
     public sealed class PassParameterByValueQuickFix : QuickFixBase
     {
-        //TODO: Change this to IDeclarationFinderProvider once the FIXME below is handled.
-        private readonly RubberduckParserState _state;
+        private readonly IDeclarationFinderProvider _declarationFinderProvider;
 
-        public PassParameterByValueQuickFix(RubberduckParserState state)
+        public PassParameterByValueQuickFix(IDeclarationFinderProvider declarationFinderProvider)
             : base(typeof(ParameterCanBeByValInspection))
         {
-            _state = state;
+            _declarationFinderProvider = declarationFinderProvider;
         }
 
         public override void Fix(IInspectionResult result, IRewriteSession rewriteSession)
         {
             if (result.Target.ParentDeclaration.DeclarationType == DeclarationType.Event ||
-                _state.DeclarationFinder.FindAllInterfaceMembers().Contains(result.Target.ParentDeclaration))
+                _declarationFinderProvider.DeclarationFinder.FindAllInterfaceMembers().Contains(result.Target.ParentDeclaration))
             {
                 FixMethods(result.Target, rewriteSession);
             }
@@ -62,7 +61,7 @@ public override void Fix(IInspectionResult result, IRewriteSession rewriteSessio
         private void FixMethods(Declaration target, IRewriteSession rewriteSession)
         {
             var declarationParameters =
-                _state.DeclarationFinder.UserDeclarations(DeclarationType.Parameter)
+                _declarationFinderProvider.DeclarationFinder.UserDeclarations(DeclarationType.Parameter)
                     .Where(declaration => Equals(declaration.ParentDeclaration, target.ParentDeclaration))
                     .OrderBy(o => o.Selection.StartLine)
                     .ThenBy(t => t.Selection.StartColumn)
@@ -75,18 +74,18 @@ private void FixMethods(Declaration target, IRewriteSession rewriteSession)
             }
 
             var members = target.ParentDeclaration.DeclarationType == DeclarationType.Event
-                ? _state.DeclarationFinder
+                ? _declarationFinderProvider.DeclarationFinder
                     .FindEventHandlers(target.ParentDeclaration)
                     .ToList()
-                : _state.DeclarationFinder
+                : _declarationFinderProvider.DeclarationFinder
                     .FindInterfaceImplementationMembers(target.ParentDeclaration)
                     .Cast<Declaration>()
                     .ToList();
 
             foreach (var member in members)
             {
                 var parameters =
-                    _state.DeclarationFinder.UserDeclarations(DeclarationType.Parameter)
+                    _declarationFinderProvider.DeclarationFinder.UserDeclarations(DeclarationType.Parameter)
                         .Where(declaration => Equals(declaration.ParentDeclaration, member))
                         .OrderBy(o => o.Selection.StartLine)
                         .ThenBy(t => t.Selection.StartColumn)