Defer reference usage determination until parser is ready.

Author: comintern

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerViewModel.cs

@@ -318,6 +318,28 @@ private void HandleStateChanged(object sender, ParserStateEventArgs e)
                 Projects = new ObservableCollection<CodeExplorerItemViewModel>();
             }
 
+            if (e.State == ParserState.Ready)
+            {
+                // Finished up resolving references, so we can now update the reference nodes.
+                var referenceFolders = Projects.SelectMany(node => node.Items.OfType<CodeExplorerReferenceFolderViewModel>());
+                foreach (var library in referenceFolders.SelectMany(folder => folder.Items).OfType<CodeExplorerReferenceViewModel>())
+                {
+                    var reference = library.Reference;
+                    if (reference == null)
+                    {
+                        continue;
+                    }
+
+                    reference.IsUsed = reference.IsBuiltIn ||
+                                       _state.DeclarationFinder.IsReferenceUsedInProject(
+                                           library.Parent?.Declaration as ProjectDeclaration,
+                                           reference.ToReferenceInfo());
+                    library.IsDimmed = !reference.IsUsed;
+                }
+
+                return;
+            }
+
             IsBusy = _state.Status != ParserState.Pending && _state.Status <= ParserState.ResolvedDeclarations;
 
             if (e.State != ParserState.ResolvedDeclarations)

Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesPresenterFactory.cs

@@ -87,6 +87,13 @@ public AddRemoveReferencesPresenter Create(ProjectDeclaration project)
                     foreach (var reference in references)
                     {
                         var guid = Guid.TryParse(reference.Guid, out var result) ? result : Guid.Empty;
+
+                        // This avoids collisions when the parse actually succeeds, but the result is empty.
+                        if (guid.Equals(Guid.Empty))
+                        {
+                            guid = new Guid(priority, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
+                        }
+
                         var libraryId = new RegisteredLibraryKey(guid, reference.Major, reference.Minor);
 
                         // TODO: If for some reason the VBA reference is broken, we could technically use this to repair it. Just a thought...

Rubberduck.Core/UI/CodeExplorer/Commands/CodeExplorerFindAllReferencesCommand.cs

@@ -41,7 +41,7 @@ protected override void OnExecute(object parameter)
                 {
                     return;
                 }
-                _finder.FindAllReferences(node.Declaration, model.ToReferenceInfo());
+                _finder.FindAllReferences(node.Parent.Declaration, model.ToReferenceInfo());
                 return;
             }