Simplify binding paths in CE by moving styles closer to scopes, general cleanup.

Author: comintern

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerItemViewModel.cs

@@ -8,7 +8,7 @@
 
 namespace Rubberduck.Navigation.CodeExplorer
 {
-    public abstract class CodeExplorerItemViewModel : ViewModelBase //, ICodeExplorerDeclarationViewModel
+    public abstract class CodeExplorerItemViewModel : ViewModelBase
     {
         protected CodeExplorerItemViewModel(Declaration declaration)
         {
@@ -70,6 +70,8 @@ public bool IsVisible
             }
         }
 
+        public virtual bool IsObsolete => false;
+
         public Declaration Declaration { get; }
 
         public virtual string ToolTip => NameWithSignature;

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerMemberViewModel.cs

@@ -176,7 +176,7 @@ public void ParentComponentHasError()
         public override BitmapImage CollapsedIcon => _icon;
         public override BitmapImage ExpandedIcon => _icon;
 
-        public bool IsObsolete =>
+        public override bool IsObsolete =>
             Declaration.Annotations.Any(annotation => annotation.AnnotationType == AnnotationType.Obsolete);
     }
 }

Rubberduck.Core/UI/AddRemoveReferences/AddRemoveReferencesWindow.xaml

@@ -46,11 +46,13 @@
                                                 UpdateSourceTrigger=PropertyChanged}"
                                      x:Name="textSource" 
                                      Background="Transparent" 
-                                     Panel.ZIndex="2" />
+                                     Panel.ZIndex="2" 
+                                     VerticalContentAlignment="Center" />
                             <TextBox Text="{TemplateBinding Tag}" Background="{TemplateBinding Background}" Panel.ZIndex="1">
                                 <TextBox.Style>
                                     <Style TargetType="{x:Type TextBox}">
                                         <Setter Property="Foreground" Value="Transparent"/>
+                                        <Setter Property="VerticalContentAlignment" Value="Center"/>
                                         <Style.Triggers>
                                             <DataTrigger Binding="{Binding Path=Text, Source={x:Reference textSource}}" Value="">
                                                 <Setter Property="Foreground" Value="LightGray"/>

Rubberduck.Core/UI/CodeExplorer/CodeExplorerControl.xaml

@@ -8,7 +8,21 @@ public class BooleanToNullableDoubleConverter : IValueConverter
     {
         public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
         {
-            throw new InvalidOperationException();
+            if (!(value is double size) ||
+                !(parameter is IConvertible input))
+            {
+                return false;
+            }
+
+            try
+            {
+                // ReSharper disable once CompareOfFloatsByEqualityOperator - these are hard coded values.
+                return System.Convert.ToDouble(input) == size;
+            }
+            catch
+            {
+                return false;
+            }
         }
 
         public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)

Rubberduck.Core/UI/Converters/BooleanToNullableDoubleConverter.cs

@@ -1481,4 +1481,13 @@ NOTE: Restart is required for the setting to take effect.</value>
   <data name="References_RemoveToolTip" xml:space="preserve">
     <value>Remove from project</value>
   </data>
+  <data name="AllReferences_NoneFoundReference" xml:space="preserve">
+    <value>No references were found for project reference '{0}'.</value>
+  </data>
+  <data name="AllReferences_PerformanceWarning" xml:space="preserve">
+    <value>Search for reference '{0}' returned {1} uses. Displaying the references may negatively impact performance. Continue?</value>
+  </data>
+  <data name="PerformanceWarningCaption" xml:space="preserve">
+    <value>Performance Warning</value>
+  </data>
 </root>