Allow ImplicitDefaultMemberAssignmentInspection to be ignored. Closes #4327

Author: comintern

Rubberduck.CodeAnalysis/Inspections/Concrete/ImplicitDefaultMemberAssignmentInspection.cs

@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Linq;
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Results;
@@ -28,7 +29,10 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
                 .Where(reference =>
                 {
                     var letStmtContext = reference.Context.GetAncestor<VBAParser.LetStmtContext>();
-                    return reference.IsAssignment && letStmtContext != null && letStmtContext.LET() == null;
+                    return reference.IsAssignment 
+                           && letStmtContext != null 
+                           && letStmtContext.LET() == null
+                           && !reference.IsIgnoringInspectionResultFor(AnnotationName);
                 });
 
             return interestingReferences.Select(reference => new IdentifierReferenceInspectionResult(this,

RubberduckTests/Inspections/ImplicitDefaultMemberAssignmentInspectionTests.cs

@@ -0,0 +1,119 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading;
+using System.Threading.Tasks;
+using NUnit.Framework;
+using Rubberduck.Inspections.Concrete;
+using Rubberduck.Parsing.VBA;
+using Rubberduck.VBEditor.SafeComWrappers;
+using RubberduckTests.Mocks;
+
+namespace RubberduckTests.Inspections
+{
+    [TestFixture]
+    public class ImplicitDefaultMemberAssignmentInspectionTests
+    {
+        [Test]
+        [Ignore("Ignored pending #4390")]
+        [Category("Inspections")]
+        public void ImplicitDefaultMemberAssignment_ReturnsResult()
+        {
+            const string inputCode =
+@"Public Sub Foo(bar As Range)
+    With bar
+        .Cells(1, 1) = 42
+    End With
+End Sub
+";
+
+            var builder = new MockVbeBuilder();
+            var project = builder.ProjectBuilder("TestProject1", "TestProject1", ProjectProtection.Unprotected)
+                .AddComponent("Module1", ComponentType.StandardModule, inputCode)
+                .AddReference("Excel", MockVbeBuilder.LibraryPathMsExcel, 1, 8, true)
+                .Build();
+            var vbe = builder.AddProject(project).Build();
+
+            var parser = MockParser.Create(vbe.Object);
+            using (var state = parser.State)
+            {
+                parser.Parse(new CancellationTokenSource());
+                if (state.Status >= ParserState.Error)
+                {
+                    Assert.Inconclusive("Parser Error");
+                }
+
+                var inspection = new ImplicitDefaultMemberAssignmentInspection(state);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.AreEqual(1, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ImplicitDefaultMemberAssignment_IgnoredDoesNotReturnResult()
+        {
+            const string inputCode =
+@"Public Sub Foo(bar As Range)
+    With bar
+        '@Ignore ImplicitDefaultMemberAssignment
+        .Cells(1, 1) = 42
+    End With
+End Sub
+";
+            var builder = new MockVbeBuilder();
+            var project = builder.ProjectBuilder("TestProject1", "TestProject1", ProjectProtection.Unprotected)
+                .AddComponent("Module1", ComponentType.StandardModule, inputCode)
+                .AddReference("Excel", MockVbeBuilder.LibraryPathMsExcel, 1, 8, true)
+                .Build();
+            var vbe = builder.AddProject(project).Build();
+
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var inspection = new ImplicitDefaultMemberAssignmentInspection(state);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ImplicitDefaultMemberAssignment_ExplicitCallDoesNotReturnResult()
+        {
+            const string inputCode =
+@"Public Sub Foo(bar As Range)
+    With bar
+        .Cells(1, 1).Value = 42
+    End With
+End Sub
+";
+            var builder = new MockVbeBuilder();
+            var project = builder.ProjectBuilder("TestProject1", "TestProject1", ProjectProtection.Unprotected)
+                .AddComponent("Module1", ComponentType.StandardModule, inputCode)
+                .AddReference("Excel", MockVbeBuilder.LibraryPathMsExcel, 1, 8, true)
+                .Build();
+            var vbe = builder.AddProject(project).Build();
+
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var inspection = new ImplicitDefaultMemberAssignmentInspection(state);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void InspectionName()
+        {
+            const string inspectionName = "ImplicitDefaultMemberAssignmentInspection";
+            var inspection = new ImplicitDefaultMemberAssignmentInspection(null);
+
+            Assert.AreEqual(inspectionName, inspection.Name);
+        }
+    }
+}

RubberduckTests/RubberduckTests.csproj

@@ -108,6 +108,7 @@
     <Compile Include="CodeAnalysis\CodeMetrics\CyclomaticComplexityTests.cs" />
     <Compile Include="CodeAnalysis\CodeMetrics\LineCountTests.cs" />
     <Compile Include="CodeExplorer\CodeExplorerTests.cs" />
+    <Compile Include="Inspections\ImplicitDefaultMemberAssignmentInspectionTests.cs" />
     <Compile Include="Inspections\UnreachableCase\ExpressionFilterUnitTests.cs" />
     <Compile Include="Inspections\UnreachableCase\ParseTreeExpressionEvaluatorUnitTests.cs" />
     <Compile Include="Inspections\UnreachableCase\ParseTreeValueUnitTests.cs" />