Rewire autocomplete settings. Closes #4339

Author: comintern

Rubberduck.Core/AutoComplete/AutoCompleteService.cs

@@ -35,6 +35,7 @@ public AutoCompleteService(IGeneralConfigService configService, SelfClosingPairC
         {
             _selfClosingPairCompletion = selfClosingPairCompletion;
             _configService = configService;
+            InitializeConfig();
             _configService.SettingsChanged += ConfigServiceSettingsChanged;
         }
 

Rubberduck.Core/Common/RubberduckHooks.cs

@@ -32,7 +32,6 @@ public void HookHotkeys()
             _hooks.Clear();
 
             var config = _config.LoadConfiguration();
-            AutoComplete.ApplyAutoCompleteSettings(config);
             var settings = config.UserSettings.HotkeySettings;
 
             foreach (var hotkeySetting in settings.Settings.Where(hotkeySetting => hotkeySetting.IsEnabled))
@@ -73,7 +72,6 @@ public void Attach()
 
             try
             {
-                AutoComplete.Enable();
                 foreach (var hook in Hooks)
                 {
                     hook.Attach();
@@ -96,7 +94,6 @@ public void Detach()
 
             try
             {
-                AutoComplete.Disable();
                 foreach (var hook in Hooks)
                 {
                     hook.MessageReceived -= hook_MessageReceived;

Rubberduck.Core/Settings/ConfigurationLoader.cs

@@ -99,7 +99,8 @@ public void SaveConfiguration(Configuration toSerialize)
             var inspectOnReparse = toSerialize.UserSettings.CodeInspectionSettings.RunInspectionsOnSuccessfulParse;
             var oldAutoCompleteSettings = _autoCompleteProvider.Create().AutoCompletes.Select(s => Tuple.Create(s.Key, s.IsEnabled));
             var newAutoCompleteSettings = toSerialize.UserSettings.AutoCompleteSettings.AutoCompletes.Select(s => Tuple.Create(s.Key, s.IsEnabled));
-            var autoCompletesChanged = !oldAutoCompleteSettings.SequenceEqual(newAutoCompleteSettings);
+            var autoCompletesChanged = !oldAutoCompleteSettings.SequenceEqual(newAutoCompleteSettings) ||
+                                       toSerialize.UserSettings.AutoCompleteSettings.IsEnabled != _autoCompleteProvider.Create().IsEnabled;
 
             _generalProvider.Save(toSerialize.UserSettings.GeneralSettings);
             _hotkeyProvider.Save(toSerialize.UserSettings.HotkeySettings);