Merge remote-tracking branch 'upstream/next' into MoreTestsForSymbols

merging recent changes

Author: MDoerner

Installer Build Script.iss

@@ -52,6 +52,9 @@ Filename: "{dotnet4064}\RegAsm.exe"; Parameters: "/codebase {#AddinDLL}"; Workin
 Filename: "{dotnet4032}\RegAsm.exe"; Parameters: "/u {#AddinDLL}"; WorkingDir: "{app}"; StatusMsg: "Unregistering Controls..."; Flags: runascurrentuser runminimized; Check: Is32BitOfficeInstalled
 Filename: "{dotnet4064}\RegAsm.exe"; Parameters: "/u {#AddinDLL}"; WorkingDir: "{app}"; StatusMsg: "Unregistering Controls..."; Flags: runascurrentuser runminimized; Check: Is64BitOfficeInstalled
 
+[UninstallDelete]
+Type: filesandordirs; Name: "{localappdata}\{#AppName}"
+
 [CustomMessages]
 ; TODO add additional languages here.
 English.NETFramework40NotInstalled=Microsoft .NET Framework 4.0 installation was not detected.

RetailCoder.VBE/API/ParserState.cs

@@ -9,8 +9,6 @@
 using Rubberduck.Parsing.Preprocessing;
 using System.Globalization;
 using Rubberduck.Parsing.Symbols;
-using Rubberduck.VBEditor;
-using Rubberduck.VBEditor.Events;
 using Rubberduck.VBEditor.SafeComWrappers.VBA;
 
 namespace Rubberduck.API

RetailCoder.VBE/App.cs

@@ -1,6 +1,9 @@
-using System.IO;
+using System.Collections.Generic;
+using System.IO;
+using System.Reflection;
 using Infralution.Localization.Wpf;
 using NLog;
+using NLog.Fluent;
 using Rubberduck.Common;
 using Rubberduck.Parsing;
 using Rubberduck.Parsing.Symbols;
@@ -145,6 +148,7 @@ private void UpdateLoggingLevel()
         public void Startup()
         {
             EnsureLogFolderPathExists();
+            LogRubberduckSart();
             LoadConfig();
             CheckForLegacyIndenterSettings();
             _appMenus.Initialize();
@@ -223,6 +227,21 @@ private void CheckForLegacyIndenterSettings()
             }
         }
 
+        private void LogRubberduckSart()
+        {
+            var version = GetType().Assembly.GetName().Version.ToString();
+            GlobalDiagnosticsContext.Set("RubberduckVersion", version);
+            var headers = new List<string>
+            {
+                string.Format("Rubberduck version {0} loading:", version),
+                string.Format("\tOperating System: {0} {1}", Environment.OSVersion.VersionString, Environment.Is64BitOperatingSystem ? "x64" : "x86"),
+                string.Format("\tHost Product: {0} {1}", Application.ProductName, Environment.Is64BitProcess ? "x64" : "x86"),
+                string.Format("\tHost Version: {0}", Application.ProductVersion),
+                string.Format("\tHost Executable: {0}", Path.GetFileName(Application.ExecutablePath)),
+            };
+            Logger.Log(LogLevel.Info, string.Join(Environment.NewLine, headers));
+        }
+
         private bool _disposed;
         public void Dispose()
         {

RetailCoder.VBE/Common/Hotkeys/Hotkey.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Windows.Forms;
-using System.Windows.Input;
 using Rubberduck.Common.WinAPI;
 using NLog;
 using Rubberduck.UI;

RetailCoder.VBE/Common/Hotkeys/IHotkey.cs

@@ -1,5 +1,4 @@
 using System.Windows.Forms;
-using System.Windows.Input;
 using Rubberduck.UI.Command;
 
 namespace Rubberduck.Common.Hotkeys

RetailCoder.VBE/Common/StringExtensions.cs

@@ -1,9 +1,5 @@
 using System;
-using System.Collections.Generic;
 using System.Globalization;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Rubberduck.Common
 {

RetailCoder.VBE/Inspections/Concrete/Inspector.cs

@@ -43,7 +43,7 @@ private void UpdateInspectionSeverity(Configuration config)
                 {
                     foreach (var setting in config.UserSettings.CodeInspectionSettings.CodeInspections)
                     {
-                        if (inspection.Description == setting.Description)
+                        if (inspection.Name == setting.Name)
                         {
                             inspection.Severity = setting.Severity;
                         }

RetailCoder.VBE/Inspections/EmptyStringLiteralInspection.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Linq;
-using Antlr4.Runtime;
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Resources;
 using Rubberduck.Inspections.Results;
@@ -20,7 +19,7 @@ public EmptyStringLiteralInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.EmptyStringLiteralInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.EmptyStringLiteralInspection; } }
+        public override string Description { get { return InspectionsUI.EmptyStringLiteralInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.LanguageOpportunities; } }
 
         public IEnumerable<QualifiedContext<VBAParser.LiteralExpressionContext>> ParseTreeResults { get { return _parseTreeResults.OfType<QualifiedContext<VBAParser.LiteralExpressionContext>>(); } }

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -21,7 +21,7 @@ public ImplicitActiveSheetReferenceInspection(IVBE vbe, RubberduckParserState st
         }
 
         public override string Meta { get { return InspectionsUI.ImplicitActiveSheetReferenceInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ImplicitActiveSheetReferenceInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.ImplicitActiveSheetReferenceInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
 
         private static readonly string[] Targets = 

RetailCoder.VBE/Inspections/ImplicitActiveWorkbookReferenceInspection.cs

@@ -21,7 +21,7 @@ public ImplicitActiveWorkbookReferenceInspection(IVBE vbe, RubberduckParserState
         }
 
         public override string Meta { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
 
         private static readonly string[] Targets =