Made DebugDeclaration use the module declarations at the time of calling Load instaed of at the time of the object construction.

Author: MDoerner

Rubberduck.Parsing/Symbols/DebugDeclarations.cs

@@ -12,21 +12,23 @@ namespace Rubberduck.Parsing.Symbols
     public class DebugDeclarations : ICustomDeclarationLoader
     {
         public static Declaration DebugPrint;
-        private readonly DeclarationFinder _finder;
+        private readonly RubberduckParserState _state;
 
         public DebugDeclarations(RubberduckParserState state)
         {
-            _finder = new DeclarationFinder(state.AllDeclarations, new CommentNode[] { }, new IAnnotation[] { });
+            _state = state;
         }
 
         public IReadOnlyList<Declaration> Load()
         {
-            if (ThereIsAGlobalBuiltInErrVariableDeclaration(_finder))
+            var finder = new DeclarationFinder(_state.AllDeclarations, new CommentNode[] { }, new IAnnotation[] { });
+
+            if (ThereIsAGlobalBuiltInErrVariableDeclaration(finder))
             {
                 return new List<Declaration>();
             }
 
-            var vba = _finder.FindProject("VBA");
+            var vba = finder.FindProject("VBA");
             if (vba == null)
             {
                 // If the VBA project is null, we haven't loaded any COM references;

RubberduckTests/Refactoring/ExtractMethod/ExtractMethodParameterClassificationTests.cs

@@ -54,8 +54,8 @@ public void shouldUseEachRuleInRulesCollectionToCheckEachReference()
                 sut.classifyDeclarations(qSelection, declaration);
 
                 //Assert
-                // 2 rules on 1 referencdes = 2 validation checks
-                var expectedToVerify = 2;
+                // 2 rules on 2 references = 4 validation checks
+                var expectedToVerify = 4;
                 emRule.Verify(emr => emr.setValidFlag(It.IsAny<IdentifierReference>(), selection),
                     Times.Exactly(expectedToVerify));