Test for ignored inspection based on where the QF puts the annotation. Closes #4364

Author: comintern

Rubberduck.CodeAnalysis/Inspections/Concrete/UnassignedVariableUsageInspection.cs

@@ -21,20 +21,22 @@ public UnassignedVariableUsageInspection(RubberduckParserState state)
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             var declarations = State.DeclarationFinder.UserDeclarations(DeclarationType.Variable)
-                .Where(result => !IsIgnoringInspectionResultFor(result, AnnotationName))
-                .Where(declaration => 
-                    State.DeclarationFinder.MatchName(declaration.AsTypeName).All(d => d.DeclarationType != DeclarationType.UserDefinedType)
+                .Where(declaration =>
+                    State.DeclarationFinder.MatchName(declaration.AsTypeName)
+                        .All(d => d.DeclarationType != DeclarationType.UserDefinedType)
                     && !declaration.IsSelfAssigned
-                    && !declaration.References.Any(reference => reference.IsAssignment && !IsIgnoringInspectionResultFor(reference, AnnotationName)));
+                    && !declaration.References.Any(reference => reference.IsAssignment));
 
-            //The parameter scoping was apparently incorrect before - need to filter for the actual function.
+            //See https://github.com/rubberduck-vba/Rubberduck/issues/2010 for why these are being excluded.
+            //TODO: These need to be modified to correctly work in VB6.
             var lenFunction = BuiltInDeclarations.SingleOrDefault(s => s.DeclarationType == DeclarationType.Function && s.Scope.Equals("VBE7.DLL;VBA.Strings.Len"));
-            var lenbFunction = BuiltInDeclarations.SingleOrDefault(s => s.DeclarationType == DeclarationType.Function && s.Scope.Equals("VBE7.DLL;VBA.Strings.Len"));
+            var lenbFunction = BuiltInDeclarations.SingleOrDefault(s => s.DeclarationType == DeclarationType.Function && s.Scope.Equals("VBE7.DLL;VBA.Strings.LenB"));
 
             return declarations.Where(d => d.References.Any() &&
                                            !DeclarationReferencesContainsReference(lenFunction, d) &&
                                            !DeclarationReferencesContainsReference(lenbFunction, d))
                                .SelectMany(d => d.References)
+                               .Where(r => !r.IsIgnoringInspectionResultFor(AnnotationName))
                                .Select(r => new IdentifierReferenceInspectionResult(this,
                                                                  string.Format(InspectionResults.UnassignedVariableUsageInspection, r.IdentifierName),
                                                                  State,

RubberduckTests/Inspections/UnassignedVariableUsageInspectionTests.cs

@@ -93,11 +93,11 @@ Dim bb As Boolean
         public void UnassignedVariableUsage_Ignored_DoesNotReturnResult()
         {
             const string inputCode =
-                @"Sub Foo()
-    '@Ignore UnassignedVariableUsage
+                @"Sub Foo()    
     Dim b As Boolean
     Dim bb As Boolean
 
+'@Ignore UnassignedVariableUsage
     bb = b
 End Sub";