Replace Interceptor implementations with abstract class implementation

Author: Vogel612

Rubberduck.Inspections/Abstract/InspectionBase.cs

@@ -8,12 +8,16 @@
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.VBEditor;
+using System.Diagnostics;
+using NLog;
 
 namespace Rubberduck.Inspections.Abstract
 {
     public abstract class InspectionBase : IInspection
     {
         protected readonly RubberduckParserState State;
+
+        private readonly ILogger _logger = LogManager.GetCurrentClassLogger();
         private readonly CodeInspectionSeverity _defaultSeverity;
 
         protected InspectionBase(RubberduckParserState state, CodeInspectionSeverity defaultSeverity = CodeInspectionSeverity.Warning)
@@ -24,11 +28,6 @@ protected InspectionBase(RubberduckParserState state, CodeInspectionSeverity def
             Name = GetType().Name;
         }
 
-        /// <summary>
-        /// Gets the type of the inspection class. GetType() returns an interceptor proxy type.
-        /// </summary>
-        public abstract Type Type { get; }
-
         /// <summary>
         /// Gets a value the severity level to reset to, the "factory default" setting.
         /// </summary>
@@ -44,12 +43,6 @@ protected InspectionBase(RubberduckParserState state, CodeInspectionSeverity def
         /// </summary>
         public abstract CodeInspectionType InspectionType { get; }
 
-        /// <summary>
-        /// A method that inspects the parser state and returns all issues it can find.
-        /// </summary>
-        /// <returns></returns>
-        public abstract IEnumerable<IInspectionResult> GetInspectionResults();
-
         /// <summary>
         /// The inspection type name, obtained by reflection.
         /// </summary>
@@ -166,5 +159,21 @@ public int CompareTo(object obj)
         {
             return CompareTo(obj as IInspection);
         }
+        protected abstract IEnumerable<IInspectionResult> DoGetInspectionResults();
+
+        /// <summary>
+        /// A method that inspects the parser state and returns all issues it can find.
+        /// </summary>
+        /// <returns></returns>
+        public IEnumerable<IInspectionResult> GetInspectionResults()
+        {
+            var _stopwatch = new Stopwatch();
+            _stopwatch.Start();
+            var result = DoGetInspectionResults();
+            _stopwatch.Stop();
+            _logger.Trace("Intercepted invocation of '{0}.{1}' returned {2} objects.", GetType().Name, nameof(DoGetInspectionResults), result.Count());
+            _logger.Trace("Intercepted invocation of '{0}.{1}' ran for {2}ms", GetType().Name, nameof(DoGetInspectionResults), _stopwatch.ElapsedMilliseconds);
+            return result;
+        }
     }
 }

Rubberduck.Inspections/Concrete/ApplicationWorksheetFunctionInspection.cs

@@ -22,7 +22,7 @@ public ApplicationWorksheetFunctionInspection(RubberduckParserState state)
 
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
-        public override IEnumerable<IInspectionResult> GetInspectionResults()
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             var excel = State.DeclarationFinder.Projects.SingleOrDefault(item => !item.IsUserDefined && item.IdentifierName == "Excel");
             if (excel == null) { return Enumerable.Empty<IInspectionResult>(); }

Rubberduck.Inspections/Concrete/AssignedByValParameterInspection.cs

@@ -20,7 +20,7 @@ public AssignedByValParameterInspection(RubberduckParserState state)
 
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
-        public override IEnumerable<IInspectionResult> GetInspectionResults()
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             var parameters = State.DeclarationFinder.UserDeclarations(DeclarationType.Parameter)
                 .Cast<ParameterDeclaration>()

Rubberduck.Inspections/Concrete/ConstantNotUsedInspection.cs

@@ -22,7 +22,7 @@ public ConstantNotUsedInspection(RubberduckParserState state)
 
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
-        public override IEnumerable<IInspectionResult> GetInspectionResults()
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             var results = State.DeclarationFinder.UserDeclarations(DeclarationType.Constant)
                 .Where(declaration => declaration.Context != null

Rubberduck.Inspections/Concrete/DefaultProjectNameInspection.cs

@@ -21,7 +21,7 @@ public DefaultProjectNameInspection(RubberduckParserState state)
 
         public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
-        public override IEnumerable<IInspectionResult> GetInspectionResults()
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             var projects = State.DeclarationFinder.UserDeclarations(DeclarationType.Project)
                 .Where(item => item.IdentifierName.StartsWith("VBAProject"))

Rubberduck.Inspections/Concrete/EmptyCaseBlockInspection.cs

@@ -23,7 +23,7 @@ public EmptyCaseBlockInspection(RubberduckParserState state)
 
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
-        public override IEnumerable<IInspectionResult> GetInspectionResults()
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             return Listener.Contexts
                 .Where(result => !IsIgnoringInspectionResultFor(result.ModuleName, result.Context.Start.Line))

Rubberduck.Inspections/Concrete/EmptyDoWhileBlockInspection.cs

@@ -20,7 +20,7 @@ public EmptyDoWhileBlockInspection(RubberduckParserState state)
 
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
-        public override IEnumerable<IInspectionResult> GetInspectionResults()
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             return Listener.Contexts
                 .Where(result => !IsIgnoringInspectionResultFor(result.ModuleName, result.Context.Start.Line))

Rubberduck.Inspections/Concrete/EmptyElseBlockInspection.cs

@@ -20,7 +20,7 @@ public EmptyElseBlockInspection(RubberduckParserState state)
 
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
-        public override IEnumerable<IInspectionResult> GetInspectionResults()
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             return Listener.Contexts
                 .Where(result => !IsIgnoringInspectionResultFor(result.ModuleName, result.Context.Start.Line))

Rubberduck.Inspections/Concrete/EmptyForEachBlockInspection.cs

@@ -20,7 +20,7 @@ public EmptyForEachBlockInspection(RubberduckParserState state)
 
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
-        public override IEnumerable<IInspectionResult> GetInspectionResults()
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             return Listener.Contexts
                 .Where(result => !IsIgnoringInspectionResultFor(result.ModuleName, result.Context.Start.Line))

Rubberduck.Inspections/Concrete/EmptyForLoopBlockInspection.cs

@@ -20,7 +20,7 @@ public EmptyForLoopBlockInspection(RubberduckParserState state)
 
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
-        public override IEnumerable<IInspectionResult> GetInspectionResults()
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             return Listener.Contexts
                 .Where(result => !IsIgnoringInspectionResultFor(result.ModuleName, result.Context.Start.Line))