Merge pull request #3433 from mansellan/3430

Added try/catch and logging when a command's 'CanExecute' implementation throws an exception, to prevent derailing the entire menu creation when one single command bombs.

Author: retailcoder

RetailCoder.VBE/UI/Command/MenuItems/FormDesignerRefactorRenameCommandMenuItem.cs

@@ -15,7 +15,7 @@ public FormDesignerRefactorRenameCommandMenuItem(CommandBase command)
 
         public override bool EvaluateCanExecute(RubberduckParserState state)
         {
-            return state.Status == ParserState.Ready && Command.CanExecute(null);
+            return state != null && state.Status == ParserState.Ready && Command.CanExecute(null);
         }
     }
 }

RetailCoder.VBE/UI/Command/MenuItems/ParentMenus/ParentMenuItemBase.cs

@@ -124,7 +124,16 @@ public void EvaluateCanExecute(RubberduckParserState state)
                 var commandItem = kvp.Key as ICommandMenuItem;
                 if (commandItem != null && kvp.Value != null)
                 {
-                     kvp.Value.IsEnabled = commandItem.EvaluateCanExecute(state);
+                    try
+                    {
+                        kvp.Value.IsEnabled = commandItem.EvaluateCanExecute(state);
+                    }
+                    catch (Exception exception)
+                    {
+                        kvp.Value.IsEnabled = false;
+                        Logger.Error(exception, "Could not evaluate availability of commmand menu item {0}.", kvp.Value.Tag ?? "{Unknown}");
+                    }
+                     
                 }
             }
         }