Enhance conflicting name message on rename

It now stated the full name of the conflicting declaration.

Author: MDoerner

Rubberduck.Core/UI/Refactorings/Rename/RenameViewModel.cs

@@ -83,21 +83,31 @@ private void ValidateName()
 
         protected override void DialogOk()
         {
-            if (Target == null
-                || (_declarationFinderProvider.DeclarationFinder.FindNewDeclarationNameConflicts(NewName, Model.Target).Any()
-                    && !UserConfirmsToProceedWithConflictingName(Model.NewName, Model.Target)))
+            if (Target == null)
             {
                 base.DialogCancel();
             }
             else
             {
-                base.DialogOk();
+                var firstConflictingDeclaration = _declarationFinderProvider.DeclarationFinder
+                    .FindNewDeclarationNameConflicts(NewName, Model.Target)
+                    .FirstOrDefault();
+
+                if (firstConflictingDeclaration != null
+                    && !UserConfirmsToProceedWithConflictingName(Model.NewName, Model.Target, firstConflictingDeclaration))
+                {
+                    base.DialogCancel();
+                }
+                else
+                {
+                    base.DialogOk();
+                }
             }
         }
 
-        private bool UserConfirmsToProceedWithConflictingName(string newName, Declaration target)
+        private bool UserConfirmsToProceedWithConflictingName(string newName, Declaration target, Declaration conflictingDeclaration)
         {
-            var message = string.Format(RubberduckUI.RenameDialog_ConflictingNames, newName, target.IdentifierName);
+            var message = string.Format(RubberduckUI.RenameDialog_ConflictingNames, newName, target.IdentifierName, conflictingDeclaration.QualifiedName.ToString());
             return _messageBox?.ConfirmYesNo(message, RubberduckUI.RenameDialog_Caption) ?? false;
         }
     }

Rubberduck.Resources/RubberduckUI.Designer.cs

@@ -465,7 +465,7 @@ Warnung: Alle eigenen Einstellungen gehen dabei verloren. Die Originaldatei wird
     <value>Neu</value>
   </data>
   <data name="RenameDialog_ConflictingNames" xml:space="preserve">
-    <value>Das Umbenenen zu '{0}' wird einen Konflikt mit '{1}' auslösen.'
+    <value>Der neue Name '{0}' kollidiert mit dem Namen des existierenden Elements '{1}'. '{2}' in '{0}' umzubenennen kann zu nicht kompilierbarem Code oder einer Änderung der Logik führen.
 Wollen Sie trotzdem fortfahren?</value>
   </data>
   <data name="Rename_DeclarationType" xml:space="preserve">

Rubberduck.Resources/RubberduckUI.de.resx

@@ -484,9 +484,9 @@ Warning: All customized settings will be lost.  Your old file will be saved in '
     <value>New</value>
   </data>
   <data name="RenameDialog_ConflictingNames" xml:space="preserve">
-    <value>'{0}' conflicts with an existing name. Renaming '{1}' to '{0}' may result in uncompilable code or a change in logic.
+    <value>'{0}' conflicts with the name of the existing declaration '{1}'. Renaming '{2}' to '{0}' may result in uncompilable  code or a change in logic.
 Do you want to proceed with this rename?</value>
-    <comment>0: NewName 1: CurrentName</comment>
+    <comment>{0}: NewName {1}: conflicting declaration {2}: CurrentName</comment>
   </data>
   <data name="RenameDialog_AmbiguousSelection" xml:space="preserve">
     <value>Please ensure that exactly 1 control is selected before renaming.</value>