Make Rename dialog use the TextBoxErrorStyle

This adds error tooltips.
In addistion, renaming to the same name is allowed now.

Author: MDoerner

Rubberduck.Core/UI/Refactorings/Rename/RenameView.xaml

@@ -32,19 +32,13 @@
                        VerticalAlignment="Top"
                        Margin="0,0,5,0" />
             <TextBox Name="RenameTextBox"
+                     Style="{StaticResource TextBoxErrorStyle}"
                      Grid.Column="1"
                      Text="{Binding NewName, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
                      Height="22"
                      VerticalAlignment="Top"
                      VerticalContentAlignment="Center"
                      HorizontalAlignment="Stretch" />
-            <Image Grid.Column="1"
-                   Source="{StaticResource InvalidTextImage}"
-                   Height="16"
-                   Margin="0,-8,-8,0"
-                   HorizontalAlignment="Right"
-                   VerticalAlignment="Top"
-                   Visibility="{Binding IsValidName, Converter={StaticResource BoolToHiddenVisibility}}"/>
         </Grid>
         <Grid Grid.Row="2" Background="{x:Static SystemColors.ControlDarkBrush}" Grid.IsSharedSizeScope="True">
             <Grid HorizontalAlignment="Right"

Rubberduck.Core/UI/Refactorings/Rename/RenameViewModel.cs

@@ -1,14 +1,11 @@
 using System;
-using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
 using Rubberduck.Interaction;
-using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.Refactorings.Rename;
 using Rubberduck.Resources;
-using Rubberduck.Common;
 using Rubberduck.Refactorings.Common;
 
 namespace Rubberduck.UI.Refactorings.Rename
@@ -50,26 +47,40 @@ public string NewName
             set
             {
                 Model.NewName = value;
+                ValidateName();
                 OnPropertyChanged();
                 OnPropertyChanged(nameof(IsValidName));
             }
         }
 
-        public bool IsValidName
+        private void ValidateName()
         {
-            get
+            if (Target == null)
             {
-                if (Target == null) { return false; }
+                return;
+            }
 
-                if (VBAIdentifierValidator.IsValidIdentifier(NewName, Target.DeclarationType))
-                {
-                    return !NewName.Equals(Target.IdentifierName, StringComparison.InvariantCultureIgnoreCase);
-                }
+            var errors = VBAIdentifierValidator.SatisfiedInvalidIdentifierCriteria(NewName, Target.DeclarationType).ToList();
+
+            var originalName = Model.Target.IdentifierName;
+            if (!originalName.Equals(NewName)
+                && originalName.Equals(NewName, StringComparison.InvariantCultureIgnoreCase))
+            {
+                errors.Add(RubberduckUI.RenameDialog_OnlyCasingDifferent);
+            }
 
-                return false;
+            if (errors.Any())
+            {
+                SetErrors(nameof(NewName), errors);
+            }
+            else
+            {
+                ClearErrors();
             }
         }
 
+        public bool IsValidName => !HasErrors;
+
         protected override void DialogOk()
         {
             if (Target == null

Rubberduck.Core/UI/ViewModelBase.cs

@@ -46,7 +46,7 @@ protected static BitmapImage GetImageSource(Bitmap image)
         protected virtual void OnErrorsChanged(string propertyName = null)
         {
             ErrorsChanged?.Invoke(this, new DataErrorsChangedEventArgs(propertyName));
-            OnPropertyChanged("HasErrors");
+            OnPropertyChanged(nameof(HasErrors));
         }
 
         public IEnumerable GetErrors(string propertyName)

Rubberduck.Refactorings/Common/VBAIdentifierValidator.cs

@@ -143,5 +143,73 @@ public static bool TryMatchInvalidIdentifierCriteria(string name, DeclarationTyp
             }
             return false;
         }
+
+        /// <summary>
+        /// Evaluates an identifier string's conformance with MS-VBAL naming requirements.
+        /// </summary>
+        /// <returns>Messages for all matching invalid identifier criteria</returns>
+        public static IReadOnlyList<string> SatisfiedInvalidIdentifierCriteria(string name, DeclarationType declarationType, bool isArrayDeclaration = false)
+        {
+            var criteriaMatchMessages = new List<string>();
+
+            var maxNameLength = declarationType.HasFlag(DeclarationType.Module)
+               ? Declaration.MaxModuleNameLength 
+               : Declaration.MaxMemberNameLength;
+
+            if (string.IsNullOrEmpty(name))
+            {
+                criteriaMatchMessages.Add(RubberduckUI.InvalidNameCriteria_IsNullOrEmpty);
+            }
+
+            //Does not start with a letter
+            if (!char.IsLetter(name.First()))
+            {
+                criteriaMatchMessages.Add(string.Format(RubberduckUI.InvalidNameCriteria_DoesNotStartWithLetterFormat, name));
+            }
+
+            //Has special characters
+            if (name.Any(c => !char.IsLetterOrDigit(c) && c != '_'))
+            {
+                criteriaMatchMessages.Add(string.Format(RubberduckUI.InvalidNameCriteria_InvalidCharactersFormat, name));
+            }
+
+            //Is a reserved identifier
+            if (!declarationType.HasFlag(DeclarationType.UserDefinedTypeMember))
+            {
+                if (ReservedIdentifiers.Contains(name, StringComparer.InvariantCultureIgnoreCase))
+                {
+                    criteriaMatchMessages.Add(string.Format(RubberduckUI.InvalidNameCriteria_IsReservedKeywordFormat, name));
+                }
+            }
+            else if (isArrayDeclaration) //is a DeclarationType.UserDefinedTypeMember
+            {
+                //DeclarationType.UserDefinedTypeMember can have reserved identifier keywords
+                //...unless the declaration is an array.  Adding the parentheses causes errors.
+
+                //Name is not a reserved identifier, but when used as a UDTMember array declaration
+                //it collides with the 'Name' Statement (Renames a disk file, directory, or folder)
+                var invalidUDTArrayIdentifiers = ReservedIdentifiers.Concat(new List<string>() { "Name" });
+
+                if (invalidUDTArrayIdentifiers.Contains(name, StringComparer.InvariantCultureIgnoreCase))
+                {
+                    criteriaMatchMessages.Add(string.Format(RubberduckUI.InvalidNameCriteria_IsReservedKeywordFormat, name));
+                }
+            }
+
+            //"VBA" identifier not allowed for projects
+            if (declarationType.HasFlag(DeclarationType.Project)
+                && name.Equals("VBA", StringComparison.InvariantCultureIgnoreCase))
+            {
+                criteriaMatchMessages.Add(string.Format(RubberduckUI.InvalidNameCriteria_IsReservedKeywordFormat, name));
+            }
+
+            //Exceeds max length
+            if (name.Length > maxNameLength)
+            {
+                criteriaMatchMessages.Add(string.Format(RubberduckUI.InvalidNameCriteria_ExceedsMaximumLengthFormat, name));
+            }
+
+            return criteriaMatchMessages;
+        }
     }
 }

Rubberduck.Refactorings/Rename/RenameRefactoringAction.cs

@@ -1,4 +1,5 @@
-using Rubberduck.Parsing.Symbols;
+using System;
+using Rubberduck.Parsing.Symbols;
 
 namespace Rubberduck.Refactorings.Rename
 {
@@ -17,6 +18,12 @@ public RenameRefactoringAction(
 
         public void Refactor(RenameModel model)
         {
+            if (model?.Target == null
+                || model.Target.IdentifierName.Equals(model.NewName, StringComparison.InvariantCultureIgnoreCase))
+            {
+                return;
+            }
+
             if (IsComponentOrProjectTarget(model))
             {
                 _renameComponentOrProjectRefactoringAction.Refactor(model);

Rubberduck.Resources/RubberduckUI.Designer.cs

@@ -1682,4 +1682,7 @@ Import abgebrochen.</value>
   <data name="RefactoringFailure_AnnotateDeclaration_InvalidType" xml:space="preserve">
     <value>Das Refactoring kann Annotationen nur zu Komponenten, Methoden und Variablen hinzufügen. Die Zieldeklaration hatte allerdings den Typ '{0}'.</value>
   </data>
+  <data name="RenameDialog_OnlyCasingDifferent" xml:space="preserve">
+    <value>Es ist in VBA nicht möglich nur die Groß- und Kleinschreibung eines Namens zu ändern.</value>
+  </data>
 </root>

Rubberduck.Resources/RubberduckUI.de.resx

@@ -1896,4 +1896,7 @@ Import aborted.</value>
     <value>The refactoring can only annotate components, members and variables, but the target had type '{0}'.</value>
     <comment>{0} declaration type</comment>
   </data>
+  <data name="RenameDialog_OnlyCasingDifferent" xml:space="preserve">
+    <value>It is not possible to change only the case of an identifier in VBA.</value>
+  </data>
 </root>