feat(InputBinding): subscribe callback now supports event priority #4211
+58
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, custom input bindings could only pass a boolean value to their subscribe callback. That is, they all do something similar to this to notify Shiny of a change:
These boolean values effectively map to values of
priority: "deferred"
(true
) andpriority: "immediate"
(false
).This means, if an input wants to resend their value immediately regardless of whether the value has changed (i.e.,
priority: "event"
), that isn't possible (until now).The motivator for adding this is for
input_submit_textarea()
in rstudio/bslib#1204, where it feels like the most desirable behavior is to always resend immediately.