Use more descriptive names for events, not evt

srcts/src/file/fileProcessor.ts

@@ -227,14 +227,14 @@ class FileUploader extends FileProcessor {
     // Trigger shiny:inputchanged. Unlike a normal shiny:inputchanged event,
     // it's not possible to modify the information before the values get
     // sent to the server.
-    const evt = new EventInputChanged({
+    const inputChangedEvent = new EventInputChanged({
       name: this.id,
       value: fileInfo,
       el: this.el,
       binding: getFileInputBinding(),
       inputType: "shiny.fileupload",
     });
-    evt.triggerOn(document);
+    inputChangedEvent.triggerOn(document);
 
     this.makeRequest(
       "uploadEnd",
@@ -245,7 +245,7 @@ class FileUploader extends FileProcessor {
         this.$bar().text("Upload complete");
         // Reset the file input's value to "". This allows the same file to be
         // uploaded again. https://stackoverflow.com/a/22521275
-        $(evt.el as HTMLElement).val("");
+        $(inputChangedEvent.el as HTMLElement).val("");
       },
       (error) => {
         this.onError(error);

srcts/src/inputPolicies/inputEventDecorator.ts

@@ -12,7 +12,7 @@ class InputEventDecorator implements InputPolicy {
   setInput(nameType: string, value: unknown, opts: InputPolicyOpts): void {
     const input = splitInputNameType(nameType);
 
-    const evt = new EventInputChanged({
+    const inputChangedEvent = new EventInputChanged({
       name: input.name,
       value,
       el: opts.el || null,
@@ -25,16 +25,19 @@ class InputEventDecorator implements InputPolicy {
     // input element instead of `document`. Existing event listeners bound to
     // `document` will still detect the event due to event bubbling. #2446
     // If no `el` exists, use `document` instead. #3584
-    evt.triggerOn(opts.el || window.document);
+    inputChangedEvent.triggerOn(opts.el || window.document);
 
-    if (!evt.isDefaultPrevented()) {
-      let name = evt.name;
+    if (!inputChangedEvent.isDefaultPrevented()) {
+      let name = inputChangedEvent.name;
 
-      if (evt.inputType !== "") name += ":" + evt.inputType;
+      if (inputChangedEvent.inputType !== "")
+        name += ":" + inputChangedEvent.inputType;
 
       // Most opts aren't passed along to lower levels in the input decorator
       // stack.
-      this.target.setInput(name, evt.value, { priority: opts.priority });
+      this.target.setInput(name, inputChangedEvent.value, {
+        priority: opts.priority,
+      });
     }
   }
 }

srcts/src/shiny/shinyapp.ts

@@ -472,30 +472,30 @@ class ShinyApp {
 
     const binding = this.$bindings[name];
 
-    const evt = new EventError({ name, error, binding });
-    evt.triggerOn(binding?.el);
+    const errorEvent = new EventError({ name, error, binding });
+    errorEvent.triggerOn(binding?.el);
 
-    if (!evt.isDefaultPrevented() && binding && binding.onValueError) {
-      binding.onValueError(evt.error);
+    if (!errorEvent.isDefaultPrevented() && binding && binding.onValueError) {
+      binding.onValueError(errorEvent.error);
     }
   }
 
   async receiveOutput<T>(name: string, value: T): Promise<T | undefined> {
     const binding = this.$bindings[name];
-    const evt = new EventValue({ name, value, binding });
+    const valueEvent = new EventValue({ name, value, binding });
 
     if (this.$values[name] === value) {
-      evt.triggerOn(binding?.el);
+      valueEvent.triggerOn(binding?.el);
       return undefined;
     }
 
     this.$values[name] = value;
     delete this.$errors[name];
 
-    evt.triggerOn(binding?.el);
+    valueEvent.triggerOn(binding?.el);
 
-    if (!evt.isDefaultPrevented() && binding) {
-      await binding.onValueChange(evt.value);
+    if (!valueEvent.isDefaultPrevented() && binding) {
+      await binding.onValueChange(valueEvent.value);
     }
 
     return value;
@@ -637,13 +637,13 @@ class ShinyApp {
       msgObj.custom[type] = data;
     }
 
-    const evt = new EventMessage({ message: msgObj });
-    evt.triggerOn(document);
-    if (evt.isDefaultPrevented()) return;
+    const messageEvent = new EventMessage({ message: msgObj });
+    messageEvent.triggerOn(document);
+    if (messageEvent.isDefaultPrevented()) return;
 
     // Send msgObj.foo and msgObj.bar to appropriate handlers
     await this._sendMessagesToHandlers(
-      evt.message,
+      messageEvent.message,
       messageHandlers,
       messageHandlerOrder
     );
@@ -712,13 +712,13 @@ class ShinyApp {
           if ($obj.length > 0) {
             if (!$obj.attr("aria-live")) $obj.attr("aria-live", "polite");
             const el = $obj[0];
-            const evt = new EventUpdateInput({
+            const updateInputEvent = new EventUpdateInput({
               message: message[i].message,
               binding: inputBinding,
             });
-            evt.triggerOn(el);
-            if (!evt.isDefaultPrevented())
-              inputBinding.receiveMessage(el, evt.message);
+            updateInputEvent.triggerOn(el);
+            if (!updateInputEvent.isDefaultPrevented())
+              inputBinding.receiveMessage(el, updateInputEvent.message);
           }
         }
       }
@@ -1217,10 +1217,10 @@ class ShinyApp {
         // value for the tabset gets updated (i.e. input$tabsetId
         // should be null if there are no tabs).
         const destTabValue = getFirstTab($tabset);
-        const evt = new EventUpdateInput({
+        const updateInputEvent = new EventUpdateInput({
           binding: inputBinding,
         });
-        $tabset.trigger(evt.event);
+        updateInputEvent.triggerOn($tabset);
         inputBinding.setValue($tabset[0], destTabValue);
       }
     }