Top Dual Legends #144
Open
Top Dual Legends #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dual Legend support for the Top so that you can have multiple legends on the top of the key for specialty keys.
full_size_dual layout implementation is based on an included refactor of pr/#96 from @ogaskell to utilize only simple_layout.
In the default.scad, I utilize a cleaner(at least IMOH) implementation of the growing amount of tables that full_size introduced. Each Key is defined in a single list held within a row list within the layout list. This makes it easy to corelate the legend to the horizontal/vertical size and font change values. The layout then utilizes list comprehension to separate all the values into individual lists for passing to layout().