fix: use node.baseURI for stringifying stylesheet hrefs #1705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1bfa38c The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the stylesheet stringification logic to use ownerNode.baseURI for resolving URLs in inline <style> sheets and adds corresponding tests.
- Swap fallback from
ownerDocument.location.hreftoownerNode.baseURI - Add unit tests for null rules,
.cssRulesfallback, and inline stylesheet baseURI resolution - Include a changeset entry for the patch release
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/rrweb-snapshot/test/utils.test.ts | Added tests for stringifyStylesheet handling of missing rules, .cssRules, and inline baseURI resolution |
| packages/rrweb-snapshot/src/utils.ts | Changed fallback logic in stringifyStylesheet to use ownerNode.baseURI instead of ownerDocument.location.href |
| .changeset/lucky-trainers-joke.md | Added patch-level changeset note |
Comments suppressed due to low confidence (2)
packages/rrweb-snapshot/test/utils.test.ts:302
- [nitpick] Consider adding a test case to verify that when
stylesheet.hrefis present alongsideownerNode.baseURI, the function still prefersstylesheet.hrefoverbaseURI.
it('uses ownerNode.baseURI for inline styles', () => {
packages/rrweb-snapshot/test/utils.test.ts:293
- [nitpick] It may be worth adding a test for the scenario where
.rulesis defined but.cssRulesis missing, to ensure.rulesis correctly prioritized.
it('stringifies rules using .cssRules if .rules is missing', () => {
eoghanmurray
previously approved these changes
Jun 23, 2025
|
Would you mind running |
megboehlert
force-pushed
the
mb-use-node-baseuri-stylsheet-href
branch
from
f2dcc84 to
1bfa38c
Compare
|
@eoghanmurray pushed the lint fix just now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prioritize using the href from base tag (if present) when stringifying urls in inline stylesheets. Node.baseURI does just this. If a base tag is not present, it falls back to location.href.