Skip to content

remove unneeded app context #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove unneeded app context #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a789c65
remove uneeded app context, thus preventing flask from destorying the…
peterlada Nov 1, 2019
03efac8
Use app_context only when one already isn't present
fzembow Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/flask_rq2/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
try:
from flask_cli import ScriptInfo
except ImportError:
raise RuntimeError('Cannot import Flask CLI. Is it installed?')
raise RuntimeError("Cannot import Flask CLI. Is it installed?")


class FlaskJob(Job):
Expand All @@ -24,6 +24,7 @@ class FlaskJob(Job):
context. This requires setting the ``FLASK_APP`` environment
variable.
"""

def __init__(self, *args, **kwargs):
super(FlaskJob, self).__init__(*args, **kwargs)
self.script_info = ScriptInfo()
Expand All @@ -36,6 +37,8 @@ def load_app(self):
return app

def perform(self):
app = self.load_app()
if current_app:
return super(FlaskJob, self).perform()
self.load_app()
with app.app_context():
return super(FlaskJob, self).perform()