Skip to content

protoc plugin code generation speed improvement for large input #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 9, 2025
Merged

protoc plugin code generation speed improvement for large input #50

merged 6 commits into from
Mar 9, 2025

Conversation

@jamesdbrock
Copy link
Member

@jamesdbrock jamesdbrock commented Mar 4, 2025 •
edited
Loading

Improve generation speed for large inputs.

Code generation time drops from 9 minutes to 14 seconds for @i-am-the-slime ’s special large input case.

@jamesdbrock
Copy link
Member Author

Before:

real	8m44.861s
user	9m2.852s
sys	0m3.891s

After:

real	9m43.224s
user	10m5.383s
sys	0m3.805s

So actually not an improvement?

@jamesdbrock jamesdbrock force-pushed the manylength branch 3 times, most recently from 1bfd566 to 84cfe2f Compare March 6, 2025 00:59
@jamesdbrock
license BSD-3-Clause
e358274
@jamesdbrock
upgrade parsing
388bfa1
@jamesdbrock
nix flake update
772a48d
@jamesdbrock
plugin docs
13f6518
@jamesdbrock
manyLength fail early if not enough bytes
1f8630b 
parseLenDel fail early if not enough bytes.

Improve generation speed for large inputs? Actually no.
@jamesdbrock
parseCodeGeneratorRequestComplete
f0ccf73 
Much faster plugin code generation when input CodeGenerationRequest is
very large.
@jamesdbrock
Copy link
Member Author

This is much better.

real	0m14.690s
user	0m16.712s
sys	0m0.766s

@jamesdbrock jamesdbrock marked this pull request as ready for review March 9, 2025 14:23
@jamesdbrock jamesdbrock changed the title manyLength fail early if not enough bytes protoc plugin code generation speed improvement for large input Mar 9, 2025
@jamesdbrock jamesdbrock merged commit 1d6a740 into master Mar 9, 2025
1 check passed
@jamesdbrock jamesdbrock deleted the manylength branch March 9, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamesdbrock