Fix washing html from rcube_attachment_handler #9785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecpl
reviewed
Feb 19, 2025
This probably wasn't implemented previously because HTML-parts usually didn't run through get.php.
pabzm
force-pushed
the
fix-washing-html-from-rcmail_attachment_handler
branch
from
675a2fb to
899344c
Compare
alecpl
reviewed
Feb 20, 2025
| $is_safe = $this->is_safe(); | ||
|
|
||
| return rcmail_action_mail_index::wash_html($body, ['safe' => $is_safe, 'inline_html' => false]); | ||
| if (isset($this->part->replaces)) { |
There was a problem hiding this comment.
Should be isset($this->part) or could be $this->part instanceof rcube_message_part, I suppose.
There was a problem hiding this comment.
Why? isset() also checks the "intermediate" object and returns false without a warning, if that isn't set.
There was a problem hiding this comment.
Hmm.. you're right, it's just not what I'm used to do. If I was about to write this code, it would be: $replaces = $this->part ? $this->part->replaces : [];, but I will not insist.
There was a problem hiding this comment.
I would prefer to keep it as it is, since the current way also protects against replaces being null (for whatever reason).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably wasn't implemented previously because HTML-parts usually didn't run through get.php.
Picked from #9519