Skip to content

Conversation

@jbweb
Copy link
Contributor

@jbweb jbweb commented Oct 22, 2024

To ensure that password for LDAP Samba AD is saved correctly, iconv() must be used instead of password::hash_password().

@alecpl
Copy link
Member

alecpl commented Oct 22, 2024

I don't see why hash_password() with 'ad' method would not work. It executes rcube_charset::convert('"' . $password . '"', RCUBE_CHARSET, 'UTF-16LE'); which should do the same. Could you explain the problem?

@jbweb
Copy link
Contributor Author

jbweb commented Oct 22, 2024

I can't remember why and what was the reason, its a long time ago. Maybe its not necessary to use iconv() directly anymore. I'll close this pull request, and do some tests to see if any issues persists with the hash_password() method or not.

@jbweb jbweb closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants