Add image source label to dockerfiles #9667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get changelogs shown with Renovate a docker container has to add the source label described in the OCI Image Format Specification. For reference: https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/docker/readme.md
|
Hey @wuast94, thank you for your contribution! I'm going to merge it since it's sensible, but are you aware that the image built from this Dockerfile is only used for testing? If you intended to contribute to the images that are available via hub.docker.com please have a look at https://github.com/roundcube/roundcubemail-docker/ |
|
oh didnt see that, but would be happy to make this PR there too :) |
|
will do it next week :) |
|
Thank you for the contribution, you are now a Roundcube developer! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get changelogs shown with Renovate a docker container has to add the source label described in the OCI Image Format Specification.
For reference: https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/docker/readme.md