Skip to content

Add comment not to remove the make multiversion from Dockerfile. #5756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

Add comment not to remove the make multiversion from Dockerfile. #5756

merged 1 commit into from
Jul 3, 2025

Conversation

fujitatomoya
Copy link
Collaborator

Description

Related to #5595 (comment)

Did you use Generative AI?

No

Additional Information

@fujitatomoya fujitatomoya self-assigned this Jun 25, 2025
fujitatomoya
fujitatomoya commented Jun 25, 2025
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the comment here so that we do not break the documentation pipeline.

@fujitatomoya
Copy link
Collaborator Author

@christophebedard can you take a look? it took me some time to think about why we have make multiversion in the Dockerfile, this prevents us from doing that in the future.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2025 •
edited
Loading

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/15884901063/artifacts/3404373286.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5756/index.html in your favorite browser

christophebedard
christophebedard reviewed Jun 25, 2025
View reviewed changes
@fujitatomoya
Add comment not to remove the make multiversion from Dockerfile.
9a41b0f 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/add-comment-dockerfile branch from c3ea378 to 9a41b0f Compare June 25, 2025 19:03
@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label Jun 25, 2025
@fujitatomoya fujitatomoya merged commit 7f1d20f into rolling Jul 3, 2025
6 checks passed
@fujitatomoya fujitatomoya deleted the fujitatomoya/add-comment-dockerfile branch July 3, 2025 01:55
mergify bot pushed a commit that referenced this pull request Jul 3, 2025
@fujitatomoya @mergify
Add comment not to remove the make multiversion from Dockerfile. (#…
c34fb0a 
…5756)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7f1d20f)
@mergify mergify bot mentioned this pull request Jul 3, 2025
Merged
mergify bot pushed a commit that referenced this pull request Jul 3, 2025
@fujitatomoya @mergify
Add comment not to remove the make multiversion from Dockerfile. (#…
335bcd8 
…5756)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7f1d20f)
mergify bot pushed a commit that referenced this pull request Jul 3, 2025
@fujitatomoya @mergify
Add comment not to remove the make multiversion from Dockerfile. (#…
abba0da 
…5756)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 7f1d20f)
This was referenced Jul 3, 2025
Merged
Merged
fujitatomoya added a commit that referenced this pull request Jul 3, 2025
@mergify @fujitatomoya
Add comment not to remove the make multiversion from Dockerfile. (#…
c305b32 
…5756) (#5765)

(cherry picked from commit 7f1d20f)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this pull request Jul 3, 2025
@mergify @fujitatomoya
Add comment not to remove the make multiversion from Dockerfile. (#…
df58c9d 
…5756) (#5763)

(cherry picked from commit 7f1d20f)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this pull request Jul 3, 2025
@mergify @fujitatomoya
Add comment not to remove the make multiversion from Dockerfile. (#…
a1e7fd5 
…5756) (#5764)

(cherry picked from commit 7f1d20f)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujitatomoya @christophebedard