Replace OpenCV version string comparison with semver. (backport #1087) #1089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the ChArUco markers with
cameracalibrator
, I found out that there's an issue with the last versions of OpenCV due to the fact that versions are compared as strings and the thing goes wrong for versions 4.10 and above e.g.:I fixed the behavior by using
semver
library which is already used in the package e.g.:Hope this fix helps anyone else too despite the fact that documentation/tutorials are skipping to mention the ChArUcos as a possible pattern (like here). In my experience, ChArUcos give better results than classic chessboards.
Also a question: does anyone mind if I cherry-pick this fix here along with mine above also to the humble?
This is an automatic backport of pull request #1087 done by Mergify.