-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Refactor parameter handler #5667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
|
@SteveMacenski, if you agree on this PR I can rebase #5654 and #5446 |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
| double distance = std::numeric_limits<double>::max(); | ||
| double resolution_ = costmap_ros_->getCostmap()->getResolution(); | ||
| double dt = (params_->v_linear_max > 0.0) ? resolution_ / params_->v_linear_max : 0.0; | ||
| double resolution = costmap_ros_->getCostmap()->getResolution(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found this readability issue when running clang tidy, I will just include it in this PR instead of opening a new one
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.