Feedback

elsayedelsheikh · elsayedelsheikh · commit e5b1b2b5e4f7 · 2025-07-22T21:04:20.000+03:00
Signed-off-by: ElSayed ElSheikh &lt;elsayed.elsheikh97@gmail.com&gt;
diff --git a/nav2_ros_common/include/nav2_ros_common/lifecycle_node.hpp b/nav2_ros_common/include/nav2_ros_common/lifecycle_node.hpp
@@ -118,7 +118,7 @@ class LifecycleNode : public rclcpp_lifecycle::LifecycleNode
     const ParameterDescriptor & parameter_descriptor = ParameterDescriptor())
   {
     return nav2::declare_or_get_parameter(
-      shared_from_this(), parameter_name,
+      this, parameter_name,
       default_value, parameter_descriptor);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ class LifecycleNode : public rclcpp_lifecycle::LifecycleNode`
`118`	`118`	`const ParameterDescriptor & parameter_descriptor = ParameterDescriptor())`
`119`	`119`	`{`
`120`	`120`	`return nav2::declare_or_get_parameter(`
`121`		`- shared_from_this(), parameter_name,`
	`121`	`+ this, parameter_name,`
`122`	`122`	`default_value, parameter_descriptor);`
`123`	`123`	`}`
`124`	`124`