Skip to content

Conversation

@URJala
Copy link
Contributor

@URJala URJala commented Jul 18, 2025

For use with trajectory until node.

@urfeex urfeex self-requested a review July 21, 2025 07:48
Copy link
Collaborator

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@urfeex urfeex merged commit 2a4f234 into ros-industrial:humble-devel Jul 30, 2025
@gavanderhoorn
Copy link
Member

Bit late perhaps: was composition considered? The action definition added by this PR appears to essentially be an extension of the base FollowJointTrajectory action definition, adding (a) new field(s) and constants.

Composition would seem to make code reuse much easier (tools/controllers consuming and producing FollowJointTrajectory goals fi) while this extension makes it immediately incompatible with existing code.

@urfeex
Copy link
Collaborator

urfeex commented Aug 5, 2025

Thank you for the feedback. I agree that a composition would be better in terms of reuse. However, since the FollowJointTrajectory.action defines all the fields in the action definition, it is to my knowledge not possible to compose this. Can I add another action's goal definition to my own action goal definition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants