Skip to content

Conversation

VinDp
Copy link
Contributor

@VinDp VinDp commented Oct 30, 2024

Changed the masses to match the actual specifications, as done for ROS2 in #187.

@VinDp VinDp requested a review from fmauch October 30, 2024 15:09
@VinDp
Copy link
Contributor Author

VinDp commented Nov 27, 2024

I also added the changes from #195 to be on pair with the ROS 2 version.
While doing so I also noticed that there were some parts that could maybe be cleaned up, like in physical_parameters.yaml of the ur30. Should I include that in this PR or is it better to leave it for a different one?

Copy link
Collaborator

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got around to testing this. Thank you @VinDp

@urfeex urfeex merged commit 8515eb3 into ros-industrial:noetic-devel Mar 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants