-
Notifications
You must be signed in to change notification settings - Fork 130
Dockerfile setup improvements #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1f224de.
santib
reviewed
Jun 3, 2024
santib
reviewed
Jun 3, 2024
santib
reviewed
Jun 3, 2024
santib
reviewed
Jun 3, 2024
santib
reviewed
Jun 3, 2024
santib
reviewed
Jun 3, 2024
santib
reviewed
Jun 3, 2024
santib
reviewed
Jun 3, 2024
santib
reviewed
Jun 3, 2024
santib
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟 this is awesome
lauperalti
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this 💪 ! Excellent documentation and step by step guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Dockerfile
to run in production. It reduces image size by using only necessary dependencies, a ruby-slim image and improves memory management by using jemalloc.Dockerfile.dev
for local development. It keeps the Node binaries so we can take advantage of live reloading.docker-compose
. Now we don't need to have use volumes for live reloading as we can use the watch feature, and the web and js processes run in a single service, enabled by foreman.docker-compose.test
, configured to run specs with it (has chrome-server service and options needed only in test environment).