[RF][RS] Sync events per toy with observed data in HypoTest if needed #19448
+71
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Test Results 20 files 20 suites 3d 9h 38m 53s ⏱️ For more details on these failures, see this check. Results for commit ceac460. ♻️ This comment has been updated with latest results. |
Just printing an error message is not enough, because this might be silenced or not seen. Also, the downstream code might not always check for a `nullptr` return value and do proper error handling, leading to crashes down the line that are hard to understand.
For non-extended pdfs, the number of generated events in toy studies should be synced with the number of events in the observed dataset. Otherwise, the generation of the toy data will fail. Closes root-project#19419.
Don't run minimizer if there are no free parameters in the profile likelihood calculator. This is already done for conditional fits, but not unconditional fits. Refactor the code such that the same logic is used for both kinds of fits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-extended pdfs, the number of generated events in toy studies
should be synced with the number of events in the observed dataset.
Otherwise, the generation of the toy data will fail.
Closes #19419.