Fix missing GIF support in TASimage #19443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The builtin afterimage by default doesn't enable support for gif. Therefore, in addition to passing include directories for gif support, one also has to enable it. Fix root-project#19412 Fixup of root-project#18074 ed789d0
Test Results 21 files 21 suites 3d 7h 26m 21s ⏱️ For more details on these failures, see this check. Results for commit f309c70. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
fixGif
branch
2 times, most recently
from
c2c4661 to
e7779c3
Compare
1 task
Instead of using @ as a command separator in sed, use | as suggested by ChristianTackeGSI. Fix root-project#7786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builtin afterimage by default doesn't enable support for gif.
Therefore, in addition to passing include directories for gif support,
one also has to enable it.
Fix #19412
Fixup of #18074 ed789d0
Fix #7786