[hist] clip color to minimum if below with COLZ TH2 #19441
Conversation
Fixes root-project#19438 and improve docu
Test Results 21 files 21 suites 3d 13h 18m 34s ⏱️ For more details on these failures, see this check. Results for commit c460faf. ♻️ This comment has been updated with latest results. |
ferdymercury
changed the title
Thks couet
|
Note: I am looking at it also. There in an issue with option TEXT also. |
| @@ -1110,6 +1110,11 @@ painted with the color corresponding to the new maximum. | |||
| When the minimum of the histogram is set to a greater value than the real minimum, | |||
| the bins having a value between the real minimum and the new minimum are not drawn | |||
| unless the option `0` is set. | |||
| In other words, option `COLZ0` forces the painting of bins with content < set minimum with | |||
There was a problem hiding this comment.
Why adding this note ? it repeats what is already said
There was a problem hiding this comment.
It does not specify that it depends on whether minimum is negative or positive, right?
| hcol22->SetMaximum(100); | ||
| hcol22->SetMinimum(40); | ||
| } | ||
| End_Macro | ||
| Note that the behavior of `COLZ` is not symmetric: it does not draw values below the specified minimum, |
There was a problem hiding this comment.
Same comment. The original doc says it already.
|
Can you add the fix to option TEXT ? and at below (near line 10154) replace: by |
Sure, thanks, I can add that |
Fix by couet
This Pull request:
Changes or fixes:
Fixes #19438
and improve docu
fyi @azontikov
Checklist: