Skip to content

Add tests for std::pair and std::tuple #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented May 2, 2025

@hahnjo hahnjo added the types label May 2, 2025
@hahnjo hahnjo requested review from pcanal, silverweed and enirolf May 2, 2025 09:06
@hahnjo hahnjo self-assigned this May 2, 2025
@hahnjo hahnjo added this to the 1.0 milestone May 2, 2025
@silverweed
Copy link
Contributor

Perhaps it makes sense to add fields with nesting? pair<pair<...>, ...> and tuple<tuple<...>, ...>

@hahnjo
Copy link
Member Author

hahnjo commented May 2, 2025

Discussion from the IO meeting: we want a record type as element, so for example nested std::pair<std::pair<...>, ...> or std::tuple<std::tuple<...>, ...>. And we also want a std::variant as element type because it has a different structural role.

@hahnjo
Copy link
Member Author

hahnjo commented May 7, 2025

ping @pcanal @silverweed can you take a look? I believe I'm implementing everything we discussed last Friday.

Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking long to review, it looks good to me.

@hahnjo hahnjo force-pushed the pair-tuple branch 2 times, most recently from f868583 to d9e3972 Compare May 23, 2025 08:01
@hahnjo hahnjo merged commit 92fe4b3 into root-project:main May 23, 2025
1 check passed
@hahnjo hahnjo deleted the pair-tuple branch May 23, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test for std::tuple Test for std::pair
5 participants