Skip to content

Add tests for Real32Trunc #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

Add tests for Real32Trunc #43

merged 1 commit into from
May 2, 2025

Conversation

silverweed
Copy link
Contributor

Closes #5

@silverweed silverweed requested review from hahnjo and enirolf April 30, 2025 09:20
@silverweed silverweed self-assigned this Apr 30, 2025
hahnjo
hahnjo reviewed Apr 30, 2025
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values make sense to me, thanks! Apart from two minor comments inline, can you also link the new directory in types/fundamental/README.md?

@hahnjo hahnjo requested a review from pcanal April 30, 2025 15:48
@hahnjo hahnjo added this to the 1.0 milestone Apr 30, 2025
pcanal
pcanal reviewed Apr 30, 2025
View reviewed changes
@silverweed silverweed merged commit ce8a39a into root-project:main May 2, 2025
1 check passed
@silverweed silverweed deleted the real32trunc branch May 2, 2025 06:44
@hahnjo hahnjo added the types label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal left review comments

@hahnjo hahnjo hahnjo approved these changes

@enirolf enirolf Awaiting requested review from enirolf

Assignees

@silverweed silverweed

Labels
types
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Test for Real32Trunc column type
3 participants
@silverweed @hahnjo @pcanal