Feature/add branch code #353
Conversation
| @@ -4,7 +4,7 @@ import { TSelector, openFile } from 'jsroot'; | |||
| const selector = new TSelector(); | |||
| selector.sum = 0; | |||
| selector.count = 0; | |||
|
|
|||
| selector.addBranch('myDouble'); | |||
| selector.Begin = function() { | |||
| console.log('Begin processing'); | |||
| }; | |||
There was a problem hiding this comment.
I am getting the right result for the file called simple.root .ie
But when i am checking for the ntuple001_staff.root, I am getting very suspecious result for its fields , i.e very big numbers for field category either i am not using the correct file
If you have any other root file with the known fields please send me i will check my code for that file too
There was a problem hiding this comment.
Which branch are you querying in ntuple001_staff.root?
There was a problem hiding this comment.
Category and age I checked both but values are very large and in the end they are comming to be 0 (some last values)
There was a problem hiding this comment.
Maybe I am using corrupted version of ntuple001_staff.root file
There was a problem hiding this comment.
In theory that file is compressed and the integer values have column type SplitInt, which you cannot deserialize yet; in fact I would expect your program to throw an exception inside deserializePage()...
There was a problem hiding this comment.
Deserializing column with coltype: 19 (0x13)
Getting this value for Category which matches with this in the enum (kUInt32: 0x13),
Something is not going correct
There was a problem hiding this comment.
0x13 is actually kSplitInt32 (see table here). I think you assigned the wrong values to the constants.
Edit: I see, you took the values from the enum index in RNTupleUtil.hxx, but that's not the same values that they are encoded with on disk. You need to use the ones in the table above if you want it to work.
There was a problem hiding this comment.
Ok so just enum needs to be changed that can be done easily then ,
Thankyou very much for help
There was a problem hiding this comment.
Changed the constants value and now its working as expected
Below is the result of simple.root working fine and giving mean value
Next is the result of ntuple001_staff result and throwing the exception successfully
Then I also tried the code for another root file i created had splitReal value and that too throwing exception as required
There was a problem hiding this comment.
I think this pr can be merged @silverweed if you feel its correct and good to go!
No description provided.